When a remote candidate is added, update all prflx candidates.

webrtc/p2p/base/p2ptransportchannel.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 767 matching lines @@
         new_remote_candidate.set_password(remote_ice()->pwd);
       }
     } else {
       // The candidate belongs to the next generation. Its pwd will be set
       // when the new remote ICE credentials arrive.
       LOG(LS_WARNING) << "A remote candidate arrives with an unknown ufrag: "
                       << candidate.username();
     }
   }
 
+  // If this candidate matches what was thought to be a peer reflexive
+  // candidate, we need to update the candidate priority/etc.
+  for (Connection* conn : connections_) {
+    conn->MaybeUpdatePeerReflexiveCandidate(new_remote_candidate);
+  }
+
   // Create connections to this remote candidate.
   CreateConnections(new_remote_candidate, NULL);
 
   // Resort the connections list, which may have new elements.
   SortConnections();
 }
 
 void P2PTransportChannel::RemoveRemoteCandidate(
     const Candidate& cand_to_remove) {
   auto iter =
@@ skipping 78 matching lines @@
     if (!connection) {
       return false;
     }
     AddConnection(connection);
     LOG_J(LS_INFO, this) << "Created connection with origin=" << origin << ", ("
                          << connections_.size() << " total)";
     return true;
   }
 
   // No new connection was created.
-  // Check if this is a peer reflexive candidate.
-  connection->MaybeUpdatePeerReflexiveCandidate(remote_candidate);
-
   // It is not legal to try to change any of the parameters of an existing
   // connection; however, the other side can send a duplicate candidate.
   if (!remote_candidate.IsEquivalent(connection->remote_candidate())) {
     LOG(INFO) << "Attempt to change a remote candidate."
               << " Existing remote candidate: "
               << connection->remote_candidate().ToString()
               << "New remote candidate: " << remote_candidate.ToString();
   }
   return false;
 }
@@ skipping 794 matching lines @@
 
   // During the initial state when nothing has been pinged yet, return the first
   // one in the ordered |connections_|.
   return *(std::find_if(connections_.begin(), connections_.end(),
                         [conn1, conn2](Connection* conn) {
                           return conn == conn1 || conn == conn2;
                         }));
 }
 
 }  // namespace cricket