Allow receiving a packet on a TURN port from an unknown address.

Allow receiving a packet on a TURN port from an unknown address.

This may occur if the TURN server allows the packet through due
to its policies around CreatePermission requirements, but the
candidate has not yet been signaled.

R=honghaiz@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/ef184702f696c6cc9d5e704d03b5a78d83440d78
Cr-Commit-Position: refs/heads/master@{#13278}

[Taylor Brandstetter, 2016-06-22 23:40:31]

deadbeef@webrtc.org changed reviewers:
+ honghaiz@webrtc.org, pthatcher@webrtc.org

[Taylor Brandstetter, 2016-06-22 23:40:32]

Please take a look. This fixes the scenario where the TURN server allows a
packet through before the candidate has been signaled, but it's filtered by
turnport.cc unnecessarily. Now, the unknown address will create a prflx
candidate pair just like we normally do.

[pthatcher1, 2016-06-23 00:35:00]

lgtm

[honghaiz3, 2016-06-23 19:24:28]

lgtm

[Taylor Brandstetter, 2016-06-23 19:39:30]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-06-23 19:39:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086203004/20001

[commit-bot: I haz the power, 2016-06-23 19:41:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 19:41:53]

Try jobs failed on following builders:
  ios_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/16036)
  mac_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/12310)
  mac_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/4189)

[Taylor Brandstetter, 2016-06-23 19:44:40]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-06-23 19:44:40]

The patchset sent to the CQ was uploaded after l-g-t-m from honghaiz@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2086203004/#ps40001 (title:
"Merging with master (renaming best_connection to selected_connection)")

[commit-bot: I haz the power, 2016-06-23 19:44:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086203004/40001

[commit-bot: I haz the power, 2016-06-23 19:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 19:52:04]

Try jobs failed on following builders:
  linux_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/16133)

[Taylor Brandstetter, 2016-06-23 22:51:18]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-06-23 22:51:18]

The patchset sent to the CQ was uploaded after l-g-t-m from honghaiz@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2086203004/#ps60001 (title:
"Fixing expectation of TURN port test.")

[commit-bot: I haz the power, 2016-06-23 22:51:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086203004/60001

[commit-bot: I haz the power, 2016-06-23 23:01:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 23:01:20]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14431)

[Taylor Brandstetter, 2016-06-23 23:33:55]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-06-23 23:33:56]

The patchset sent to the CQ was uploaded after l-g-t-m from honghaiz@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2086203004/#ps80001 (title:
"Fixing memory leak found by ASan bot.")

[commit-bot: I haz the power, 2016-06-23 23:34:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086203004/80001

[commit-bot: I haz the power, 2016-06-23 23:40:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 23:40:31]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14434)

[Taylor Brandstetter, 2016-06-24 00:36:00]

Description was changed from

==========
Allow receiving a packet on a TURN port from an unknown address.

This may occur if the TURN server allows the packet through due
to its policies around CreatePermission requirements, but the
candidate has not yet been signaled.
==========

to

==========
Allow receiving a packet on a TURN port from an unknown address.

This may occur if the TURN server allows the packet through due
to its policies around CreatePermission requirements, but the
candidate has not yet been signaled.

R=honghaiz@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ef184702f696c6cc9d5e704d0...
==========

[Taylor Brandstetter, 2016-06-24 00:36:02]

Committed patchset #5 (id:80001) manually as
ef184702f696c6cc9d5e704d03b5a78d83440d78 (presubmit successful).

[commit-bot: I haz the power, 2016-06-24 00:36:04]

Description was changed from

==========
Allow receiving a packet on a TURN port from an unknown address.

This may occur if the TURN server allows the packet through due
to its policies around CreatePermission requirements, but the
candidate has not yet been signaled.

R=honghaiz@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ef184702f696c6cc9d5e704d0...
==========

to

==========
Allow receiving a packet on a TURN port from an unknown address.

This may occur if the TURN server allows the packet through due
to its policies around CreatePermission requirements, but the
candidate has not yet been signaled.

R=honghaiz@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/ef184702f696c6cc9d5e704d03b5a78d83440d78
Cr-Commit-Position: refs/heads/master@{#13278}
==========