Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: webrtc/p2p/base/turnport.cc

Issue 2086203004: Allow receiving a packet on a TURN port from an unknown address. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing memory leak found by ASan bot. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/testturnserver.h ('k') | webrtc/p2p/base/turnport_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/turnport.cc
diff --git a/webrtc/p2p/base/turnport.cc b/webrtc/p2p/base/turnport.cc
index 824a25e644ba1c48eeb49f022933630f68059ee3..567916f4baf6ae2b5f385421b58438f12e768e08 100644
--- a/webrtc/p2p/base/turnport.cc
+++ b/webrtc/p2p/base/turnport.cc
@@ -831,13 +831,13 @@ void TurnPort::HandleDataIndication(const char* data, size_t size,
return;
}
- // Verify that the data came from somewhere we think we have a permission for.
+ // Log a warning if the data didn't come from an address that we think we have
+ // a permission for.
rtc::SocketAddress ext_addr(addr_attr->GetAddress());
if (!HasPermission(ext_addr.ipaddr())) {
- LOG_J(LS_WARNING, this) << "Received TURN data indication with invalid "
- << "peer address, addr="
- << ext_addr.ToSensitiveString();
- return;
+ LOG_J(LS_WARNING, this)
+ << "Received TURN data indication with unknown "
+ << "peer address, addr=" << ext_addr.ToSensitiveString();
}
DispatchPacket(data_attr->bytes(), data_attr->length(), ext_addr,
« no previous file with comments | « webrtc/p2p/base/testturnserver.h ('k') | webrtc/p2p/base/turnport_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698