Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2082643004: Revert of Delete method cricket::VideoFrame::Copy. (Closed)

Created:
4 years, 6 months ago by nisse-webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, Sergey Ulanov
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete method cricket::VideoFrame::Copy. (patchset #7 id:120001 of https://codereview.webrtc.org/2080253002/ ) Reason for revert: Breaks chrome, because a new use of Copy was added in cl https://codereview.chromium.org/2062843003 Original issue's description: > Delete method cricket::VideoFrame::Copy. > > Should be unused in Chrome since cl > https://codereview.chromium.org/2068703002/ > > TBR=tkchin@webrtc.org,magjed@webrtc.org > BUG=webrtc:5682 > > Committed: https://crrev.com/9c00f646f0b3cd33506a1944c7bc6724af041237 > Cr-Commit-Position: refs/heads/master@{#13236} TBR=pbos@webrtc.org,tkchin@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/3a2a6404b13857c7de0c71ea88e4f70f0066afa3 Cr-Commit-Position: refs/heads/master@{#13238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -13 lines) Patch
M talk/app/webrtc/objc/RTCI420Frame.mm View 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/media/base/videoframe.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 1 chunk +25 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoFrame.mm View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nisse-webrtc
Created Revert of Delete method cricket::VideoFrame::Copy.
4 years, 6 months ago (2016-06-21 11:16:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082643004/1
4 years, 6 months ago (2016-06-21 11:17:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 11:17:32 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 11:17:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a2a6404b13857c7de0c71ea88e4f70f0066afa3
Cr-Commit-Position: refs/heads/master@{#13238}

Powered by Google App Engine
This is Rietveld 408576698