Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2080573004: Remove DesktopCapturer::Callback::OnCaptureCompleted() (Closed)

Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
4 years, 6 months ago
Reviewers:
Wez
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove DesktopCapturer::Callback::OnCaptureCompleted() The method was deprecated and shouldn't be used anywhere now. BUG=webrtc:5950 Committed: https://crrev.com/6ef36e708f47eb3a42c42091ab975a2186700604 Cr-Commit-Position: refs/heads/master@{#13248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M webrtc/modules/desktop_capture/desktop_capturer.h View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sergey Ulanov
4 years, 6 months ago (2016-06-21 21:16:47 UTC) #3
Wez
lgtm
4 years, 6 months ago (2016-06-21 22:33:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080573004/1
4 years, 6 months ago (2016-06-21 23:15:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 23:50:07 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 23:50:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ef36e708f47eb3a42c42091ab975a2186700604
Cr-Commit-Position: refs/heads/master@{#13248}

Powered by Google App Engine
This is Rietveld 408576698