Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: webrtc/modules/desktop_capture/desktop_capturer.h

Issue 2080573004: Remove DesktopCapturer::Callback::OnCaptureCompleted() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/desktop_capture/desktop_capturer.h
diff --git a/webrtc/modules/desktop_capture/desktop_capturer.h b/webrtc/modules/desktop_capture/desktop_capturer.h
index d6da81d9fedb70ba191a9ad16d30b5714edad221..778c93c63a0e638d75a110be7fa57c237f565a29 100644
--- a/webrtc/modules/desktop_capture/desktop_capturer.h
+++ b/webrtc/modules/desktop_capture/desktop_capturer.h
@@ -47,15 +47,7 @@ class DesktopCapturer {
// Called after a frame has been captured. |frame| is not nullptr if and
// only if |result| is SUCCESS.
virtual void OnCaptureResult(Result result,
- std::unique_ptr<DesktopFrame> frame) {
- OnCaptureCompleted(frame.release());
- }
-
- // Deprecated version of the method above that uses raw pointer instead of
- // std::unique_ptr<>.
- // TODO(sergeyu): Remove this method and make OnCaptureResult() pure
- // virtual. crbug.com/webrtc/5950
- virtual void OnCaptureCompleted(DesktopFrame* frame) { delete frame; };
+ std::unique_ptr<DesktopFrame> frame) = 0;
protected:
virtual ~Callback() {}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698