Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2080253002: Delete method cricket::VideoFrame::Copy. (Closed)

Created:
4 years, 6 months ago by nisse-webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete method cricket::VideoFrame::Copy. Should be unused in Chrome since cl https://codereview.chromium.org/2068703002/ TBR=tkchin@webrtc.org,magjed@webrtc.org BUG=webrtc:5682 Committed: https://crrev.com/9c00f646f0b3cd33506a1944c7bc6724af041237 Committed: https://crrev.com/7e4e00d189a5dfac2b463a5100ee65ee2f11ed79 Cr-Original-Commit-Position: refs/heads/master@{#13236} Cr-Commit-Position: refs/heads/master@{#13244}

Patch Set 1 #

Patch Set 2 : Update initWithNativeFrame: #

Patch Set 3 : Android and objc fixes. #

Patch Set 4 : Add a (forbidden) include. Advice needed. #

Patch Set 5 : Update talk version too. #

Patch Set 6 : Another attempt at getting includes right. #

Patch Set 7 : Fix syntax error in objc files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -61 lines) Patch
M talk/app/webrtc/objc/RTCI420Frame.mm View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/media/base/videoframe.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 1 chunk +0 lines, -25 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoFrame.mm View 1 2 3 4 5 6 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 30 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080253002/1
4 years, 6 months ago (2016-06-20 12:21:13 UTC) #2
nisse-webrtc
4 years, 6 months ago (2016-06-20 12:22:52 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/10628) mac_rel on ...
4 years, 6 months ago (2016-06-20 12:24:29 UTC) #6
pbos-webrtc
lgtm
4 years, 6 months ago (2016-06-20 12:25:35 UTC) #7
pbos-webrtc
On 2016/06/20 12:25:35, pbos-webrtc wrote: > lgtm talk/app/webrtc/objc/RTCI420Frame.mm:101:35: error: no member named 'Copy' in 'cricket::VideoFrame'
4 years, 6 months ago (2016-06-20 12:26:04 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080253002/120001
4 years, 6 months ago (2016-06-21 08:38:59 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 09:13:59 UTC) #12
pbos-webrtc
lgtm
4 years, 6 months ago (2016-06-21 10:40:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080253002/120001
4 years, 6 months ago (2016-06-21 11:02:51 UTC) #17
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 6 months ago (2016-06-21 11:04:28 UTC) #19
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/9c00f646f0b3cd33506a1944c7bc6724af041237 Cr-Commit-Position: refs/heads/master@{#13236}
4 years, 6 months ago (2016-06-21 11:04:36 UTC) #21
nisse-webrtc
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.webrtc.org/2082643004/ by nisse@webrtc.org. ...
4 years, 6 months ago (2016-06-21 11:16:25 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080253002/120001
4 years, 6 months ago (2016-06-21 19:45:32 UTC) #25
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 6 months ago (2016-06-21 19:53:52 UTC) #27
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/7e4e00d189a5dfac2b463a5100ee65ee2f11ed79 Cr-Commit-Position: refs/heads/master@{#13244}
4 years, 6 months ago (2016-06-21 19:54:04 UTC) #29
honghaiz3
4 years, 6 months ago (2016-06-21 21:02:36 UTC) #30
Message was sent while issue was closed. 
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.webrtc.org/2087923004/ by honghaiz@webrtc.org.

The reason for reverting is: It broke a downstream build by removing
VideoFrame::Copy method. .

Powered by Google App Engine
This is Rietveld 408576698