Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2080163002: Remove dead GYP target audio_device_module_java (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dead GYP target audio_device_module_java This is no longer referenced after https://codereview.webrtc.org/1439593002 was submitted. NOTRY=True Committed: https://crrev.com/02343b9ae22c02b5a1e7b93230f6b46f5a8b1dfc Cr-Commit-Position: refs/heads/master@{#13209}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46 lines) Patch
M webrtc/build/common.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
D webrtc/modules/modules_java.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/modules/modules_java_chromium.gyp View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-20 07:53:54 UTC) #2
henrika_webrtc
LGTM
4 years, 6 months ago (2016-06-20 08:42:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080163002/1
4 years, 6 months ago (2016-06-20 08:42:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 08:43:41 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 08:43:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02343b9ae22c02b5a1e7b93230f6b46f5a8b1dfc
Cr-Commit-Position: refs/heads/master@{#13209}

Powered by Google App Engine
This is Rietveld 408576698