Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1439593002: Remove webrtc/examples/android/media_demo. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc/examples/android/media_demo. The JNI code for VoiceEngine is not maintained and VoiceEngine is being refactored. This is not a supported Java interface, use AppRTCDemo as a starting point instead. Also renames webrtc/libjingle_examples.gyp webrtc/webrtc_examples.gyp to replace the previous file (that only contained media_demo). BUG= R=henrika@webrtc.org, kjellander@webrtc.org Committed: https://crrev.com/fa566d610fe26a7007246ad84295aaaac6da15cf Cr-Commit-Position: refs/heads/master@{#10599}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -2754 lines) Patch
M .gitignore View 1 chunk +0 lines, -6 lines 0 comments Download
M all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M talk/libjingle_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/examples/android/media_demo/AndroidManifest.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D webrtc/examples/android/media_demo/README View 1 chunk +0 lines, -24 lines 0 comments Download
D webrtc/examples/android/media_demo/build.xml View 1 chunk +0 lines, -92 lines 0 comments Download
D webrtc/examples/android/media_demo/jni/jni_helpers.h View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/examples/android/media_demo/jni/jni_helpers.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D webrtc/examples/android/media_demo/jni/on_load.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/examples/android/media_demo/jni/voice_engine_jni.h View 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/examples/android/media_demo/jni/voice_engine_jni.cc View 1 chunk +0 lines, -423 lines 0 comments Download
D webrtc/examples/android/media_demo/project.properties View 1 chunk +0 lines, -14 lines 0 comments Download
D webrtc/examples/android/media_demo/res/drawable/logo.png View Binary file 0 comments Download
D webrtc/examples/android/media_demo/res/layout/audiomenu.xml View 1 chunk +0 lines, -80 lines 0 comments Download
D webrtc/examples/android/media_demo/res/layout/dropdownitems.xml View 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/examples/android/media_demo/res/layout/mainmenu.xml View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/examples/android/media_demo/res/layout/settingsmenu.xml View 1 chunk +0 lines, -36 lines 0 comments Download
D webrtc/examples/android/media_demo/res/menu/main_activity_actions.xml View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/examples/android/media_demo/res/values/bools.xml View 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/examples/android/media_demo/res/values/integers.xml View 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/examples/android/media_demo/res/values/strings.xml View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/AudioMenuFragment.java View 1 chunk +0 lines, -156 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/CodecInst.java View 1 chunk +0 lines, -39 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/MainMenuFragment.java View 1 chunk +0 lines, -123 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/MediaEngine.java View 1 chunk +0 lines, -321 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/MediaEngineObserver.java View 1 chunk +0 lines, -15 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/MenuStateProvider.java View 1 chunk +0 lines, -15 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/NativeWebRtcContextRegistry.java View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/RtcpStatistics.java View 1 chunk +0 lines, -32 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/SettingsMenuFragment.java View 1 chunk +0 lines, -129 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/SpinnerAdapter.java View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/VoiceEngine.java View 1 chunk +0 lines, -117 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/WebRTCDemo.java View 1 chunk +0 lines, -210 lines 0 comments Download
D webrtc/libjingle_examples.gyp View 1 chunk +0 lines, -409 lines 0 comments Download
M webrtc/webrtc_examples.gyp View 1 2 chunks +379 lines, -61 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
pbos-webrtc
PTAL, I consider this dead code since it's not something we want to maintain (and ...
5 years, 1 month ago (2015-11-11 11:32:16 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439593002/1
5 years, 1 month ago (2015-11-11 11:32:35 UTC) #3
henrika_webrtc
LGTM
5 years, 1 month ago (2015-11-11 11:36:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439593002/1
5 years, 1 month ago (2015-11-11 11:42:15 UTC) #8
kjellander_webrtc
lgtm with nit https://codereview.webrtc.org/1439593002/diff/1/webrtc/webrtc_examples.gyp File webrtc/webrtc_examples.gyp (right): https://codereview.webrtc.org/1439593002/diff/1/webrtc/webrtc_examples.gyp#newcode1 webrtc/webrtc_examples.gyp:1: # nit: remove this blank line
5 years, 1 month ago (2015-11-11 12:03:38 UTC) #9
pbos-webrtc
remove empty line
5 years, 1 month ago (2015-11-11 12:07:40 UTC) #11
pbos-webrtc
Committed patchset #2 (id:20001) manually as fa566d610fe26a7007246ad84295aaaac6da15cf (presubmit successful).
5 years, 1 month ago (2015-11-11 12:11:28 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fa566d610fe26a7007246ad84295aaaac6da15cf Cr-Commit-Position: refs/heads/master@{#10599}
5 years, 1 month ago (2015-11-11 12:11:29 UTC) #14
pbos-webrtc
5 years, 1 month ago (2015-11-11 12:12:08 UTC) #15
Message was sent while issue was closed.
https://codereview.webrtc.org/1439593002/diff/1/webrtc/webrtc_examples.gyp
File webrtc/webrtc_examples.gyp (right):

https://codereview.webrtc.org/1439593002/diff/1/webrtc/webrtc_examples.gyp#ne...
webrtc/webrtc_examples.gyp:1: #
On 2015/11/11 12:03:37, kjellander (webrtc) wrote:
> nit: remove this blank line

Done.

Powered by Google App Engine
This is Rietveld 408576698