Rewrite CreateBlackFrame in webrtcvideoengine.

Rewrite CreateBlackFrame in webrtcvideoengine.

Don't use VideoFrameBuffer::MutableDataY and friends, instead, use
I420Buffer::SetToBlack.

Also introduce static method I420Buffer::Create, to create an object and
return a scoped_refptr.

TBR=marpan@webrtc.org # Trivial change to video_denoiser.cc
BUG=webrtc:5921
Committed: https://crrev.com/ac62bd4a3b9add714566e3c2b4e92621dda92792
Cr-Commit-Position: refs/heads/master@{#13212}

[nisse-webrtc, 2016-06-17 12:24:54]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2016-06-17 12:30:38]

https://codereview.webrtc.org/2078943002/diff/1/webrtc/media/engine/webrtcvid...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/2078943002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2.cc:1682: black_buffer,  0 /* timestamp
(90 kHz) */,
Is this (zero-timestamp) the same as before? If so this might just be dropped,
I'm not sure if this code is alive.

[nisse-webrtc, 2016-06-17 13:26:12]

https://codereview.webrtc.org/2078943002/diff/1/webrtc/media/engine/webrtcvid...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/2078943002/diff/1/webrtc/media/engine/webrtcvid...
webrtc/media/engine/webrtcvideoengine2.cc:1682: black_buffer,  0 /* timestamp
(90 kHz) */,
On 2016/06/17 12:30:38, pbos-webrtc wrote:
> Is this (zero-timestamp) the same as before? If so this might just be dropped,
> I'm not sure if this code is alive.

Before this cl, the 90 kHz timestamp on the frame was set to zero by the
webrtc::VideoFrame default initializer. 

And if you look at the OnFrame method, it also sets render_time_ms only. The
other two timestamps are populated by some pretty convoluted logic further down
the pipeline.

And I think the black-frame-on-source-change is tested by
WebRtcVideoChannel2BaseTest.AddRemoveCapturer, so it's somewhat alive.

[pbos-webrtc, 2016-06-17 14:04:49]

Thanks, lgtm

[nisse-webrtc, 2016-06-17 14:08:44]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-06-17 14:08:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2078943002/1

[commit-bot: I haz the power, 2016-06-17 14:27:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 14:27:45]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6383)

[nisse-webrtc, 2016-06-20 10:01:37]

Description was changed from

==========
Rewrite CreateBlackFrame in webrtcvideoengine.

Don't use VideoFrameBuffer::MutableDataY and friends, instead, use
I420Buffer::SetToBlack.

Also introduce static method I420Buffer::Create, to create an object and
return a scoped_refptr.

BUG=webrtc:5921
==========

to

==========
Rewrite CreateBlackFrame in webrtcvideoengine.

Don't use VideoFrameBuffer::MutableDataY and friends, instead, use
I420Buffer::SetToBlack.

Also introduce static method I420Buffer::Create, to create an object and
return a scoped_refptr.

TBR=marpan@webrtc.org # Trivial change to video_denoiser.cc
BUG=webrtc:5921
==========

[nisse-webrtc, 2016-06-20 10:02:01]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-06-20 10:02:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2078943002/1

[commit-bot: I haz the power, 2016-06-20 10:38:55]

Description was changed from

==========
Rewrite CreateBlackFrame in webrtcvideoengine.

Don't use VideoFrameBuffer::MutableDataY and friends, instead, use
I420Buffer::SetToBlack.

Also introduce static method I420Buffer::Create, to create an object and
return a scoped_refptr.

TBR=marpan@webrtc.org # Trivial change to video_denoiser.cc
BUG=webrtc:5921
==========

to

==========
Rewrite CreateBlackFrame in webrtcvideoengine.

Don't use VideoFrameBuffer::MutableDataY and friends, instead, use
I420Buffer::SetToBlack.

Also introduce static method I420Buffer::Create, to create an object and
return a scoped_refptr.

TBR=marpan@webrtc.org # Trivial change to video_denoiser.cc
BUG=webrtc:5921
==========

[commit-bot: I haz the power, 2016-06-20 10:38:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-20 10:39:04]

Description was changed from

==========
Rewrite CreateBlackFrame in webrtcvideoengine.

Don't use VideoFrameBuffer::MutableDataY and friends, instead, use
I420Buffer::SetToBlack.

Also introduce static method I420Buffer::Create, to create an object and
return a scoped_refptr.

TBR=marpan@webrtc.org # Trivial change to video_denoiser.cc
BUG=webrtc:5921
==========

to

==========
Rewrite CreateBlackFrame in webrtcvideoengine.

Don't use VideoFrameBuffer::MutableDataY and friends, instead, use
I420Buffer::SetToBlack.

Also introduce static method I420Buffer::Create, to create an object and
return a scoped_refptr.

TBR=marpan@webrtc.org # Trivial change to video_denoiser.cc
BUG=webrtc:5921

Committed: https://crrev.com/ac62bd4a3b9add714566e3c2b4e92621dda92792
Cr-Commit-Position: refs/heads/master@{#13212}
==========

[commit-bot: I haz the power, 2016-06-20 10:39:06]

Patchset 1 (id:??) landed as
https://crrev.com/ac62bd4a3b9add714566e3c2b4e92621dda92792
Cr-Commit-Position: refs/heads/master@{#13212}