Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: webrtc/common_video/video_frame_buffer.cc

Issue 2078943002: Rewrite CreateBlackFrame in webrtcvideoengine. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/common_video/video_frame_buffer.cc
diff --git a/webrtc/common_video/video_frame_buffer.cc b/webrtc/common_video/video_frame_buffer.cc
index 14e19dc0e33f4bd90b07345ec387dd9b29495f40..2875c661c8b3835f4c70ec706c12f9e66992038b 100644
--- a/webrtc/common_video/video_frame_buffer.cc
+++ b/webrtc/common_video/video_frame_buffer.cc
@@ -134,6 +134,19 @@ I420Buffer::I420Buffer(int width,
I420Buffer::~I420Buffer() {
}
+rtc::scoped_refptr<I420Buffer> I420Buffer::Create(int width, int height) {
+ return new rtc::RefCountedObject<I420Buffer>(width, height);
+}
+
+rtc::scoped_refptr<I420Buffer> I420Buffer::Create(int width,
+ int height,
+ int stride_y,
+ int stride_u,
+ int stride_v) {
+ return new rtc::RefCountedObject<I420Buffer>(
+ width, height, stride_y, stride_u, stride_v);
+}
+
void I420Buffer::InitializeData() {
memset(data_.get(), 0,
I420DataSize(height_, stride_y_, stride_u_, stride_v_));
@@ -190,8 +203,7 @@ rtc::scoped_refptr<I420Buffer> I420Buffer::Copy(
const rtc::scoped_refptr<VideoFrameBuffer>& source) {
int width = source->width();
int height = source->height();
- rtc::scoped_refptr<I420Buffer> target =
- new rtc::RefCountedObject<I420Buffer>(width, height);
+ rtc::scoped_refptr<I420Buffer> target = I420Buffer::Create(width, height);
RTC_CHECK(libyuv::I420Copy(source->DataY(), source->StrideY(),
source->DataU(), source->StrideU(),
source->DataV(), source->StrideV(),
@@ -273,8 +285,7 @@ rtc::scoped_refptr<I420Buffer> I420Buffer::CopyKeepStride(
int stride_u = source->StrideU();
int stride_v = source->StrideV();
rtc::scoped_refptr<I420Buffer> target =
- new rtc::RefCountedObject<I420Buffer>(
- width, height, stride_y, stride_u, stride_v);
+ I420Buffer::Create(width, height, stride_y, stride_u, stride_v);
RTC_CHECK(libyuv::I420Copy(source->DataY(), stride_y,
source->DataU(), stride_u,
source->DataV(), stride_v,

Powered by Google App Engine
This is Rietveld 408576698