- Remove use of VoERTP_RTCP::SetLocalSSRC() for receive streams; recreate them instead.

- Remove use of VoERTP_RTCP::SetLocalSSRC() for receive streams; recreate them instead.
- Remove VoERTP_RTCP from VoEWrapper and FakeWebRtcVoiceEngine.

BUG=webrtc:4690
Committed: https://crrev.com/4a0f7b508d3faa799bb2462570de5c224af733b1
Cr-Commit-Position: refs/heads/master@{#13174}

[the sun, 2016-06-16 17:55:42]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[the sun, 2016-06-16 19:07:45]

Description was changed from

==========
- Remove use of VoERTP_RTCP::SetLocalSSRC() for receive streams; recreate them
instead.
- Remove VoERTP_RTCP from VoEWrapper and FakeWebRtcVoiceEngine.

BUG=webrtc:4690
==========

to

==========
- Remove use of VoERTP_RTCP::SetLocalSSRC() for receive streams; recreate them
instead.
- Remove VoERTP_RTCP from VoEWrapper and FakeWebRtcVoiceEngine.

BUG=webrtc:4690
==========

[the sun, 2016-06-16 19:07:45]

solenberg@webrtc.org changed reviewers:
+ pthatcher@webrtc.org
- kwiberg@webrtc.org

[pthatcher1, 2016-06-16 19:20:02]

lgtm

https://codereview.webrtc.org/2072783002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2072783002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:2046: int recv_channel =
kv.second->channel();
Could you make a comment that this may cause callee receive streams to be
recreated for every call unless we can pass in the the receiver's SSRC in from
the application (which we're supposed to be able to do with ORTC someday)? 

Perhaps make it a TODO to allow applications to set the receiver's RTCP SSRC?

[the sun, 2016-06-16 19:34:21]

https://codereview.webrtc.org/2072783002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2072783002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:2046: int recv_channel =
kv.second->channel();
On 2016/06/16 19:20:02, pthatcher1 wrote:
> Could you make a comment that this may cause callee receive streams to be
> recreated for every call unless we can pass in the the receiver's SSRC in from
> the application (which we're supposed to be able to do with ORTC someday)? 
> 
> Perhaps make it a TODO to allow applications to set the receiver's RTCP SSRC?

Done.

[the sun, 2016-06-16 19:35:01]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-06-16 19:35:01]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2072783002/#ps40001 (title:
"rebase+added comment")

[commit-bot: I haz the power, 2016-06-16 19:35:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072783002/40001

[commit-bot: I haz the power, 2016-06-16 20:07:37]

Description was changed from

==========
- Remove use of VoERTP_RTCP::SetLocalSSRC() for receive streams; recreate them
instead.
- Remove VoERTP_RTCP from VoEWrapper and FakeWebRtcVoiceEngine.

BUG=webrtc:4690
==========

to

==========
- Remove use of VoERTP_RTCP::SetLocalSSRC() for receive streams; recreate them
instead.
- Remove VoERTP_RTCP from VoEWrapper and FakeWebRtcVoiceEngine.

BUG=webrtc:4690
==========

[commit-bot: I haz the power, 2016-06-16 20:07:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-16 20:07:46]

Description was changed from

==========
- Remove use of VoERTP_RTCP::SetLocalSSRC() for receive streams; recreate them
instead.
- Remove VoERTP_RTCP from VoEWrapper and FakeWebRtcVoiceEngine.

BUG=webrtc:4690
==========

to

==========
- Remove use of VoERTP_RTCP::SetLocalSSRC() for receive streams; recreate them
instead.
- Remove VoERTP_RTCP from VoEWrapper and FakeWebRtcVoiceEngine.

BUG=webrtc:4690

Committed: https://crrev.com/4a0f7b508d3faa799bb2462570de5c224af733b1
Cr-Commit-Position: refs/heads/master@{#13174}
==========

[commit-bot: I haz the power, 2016-06-16 20:07:47]

Patchset 3 (id:??) landed as
https://crrev.com/4a0f7b508d3faa799bb2462570de5c224af733b1
Cr-Commit-Position: refs/heads/master@{#13174}