Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: webrtc/media/engine/webrtcvoiceengine_unittest.cc

Issue 2072783002: - Remove use of VoERTP_RTCP::SetLocalSSRC() for receive streams; recreate them instead. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase+added comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvoiceengine_unittest.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine_unittest.cc b/webrtc/media/engine/webrtcvoiceengine_unittest.cc
index 7c2536716478b01326db29332c723c0efcd05279..167ec89267e63381d8fcd1738324d013d2d8484f 100644
--- a/webrtc/media/engine/webrtcvoiceengine_unittest.cc
+++ b/webrtc/media/engine/webrtcvoiceengine_unittest.cc
@@ -59,7 +59,6 @@ class FakeVoEWrapper : public cricket::VoEWrapper {
engine, // base
engine, // codec
engine, // hw
- engine, // rtp
engine) { // volume
}
};
@@ -2508,13 +2507,11 @@ TEST_F(WebRtcVoiceEngineTestFake, SetSendSsrcWithMultipleStreams) {
// receive channel is created before the send channel.
TEST_F(WebRtcVoiceEngineTestFake, SetSendSsrcAfterCreatingReceiveChannel) {
EXPECT_TRUE(SetupChannel());
- EXPECT_TRUE(AddRecvStream(1));
- int receive_channel_num = voe_.GetLastChannel();
+ EXPECT_TRUE(AddRecvStream(kSsrc2));
EXPECT_TRUE(channel_->AddSendStream(
- cricket::StreamParams::CreateLegacy(1234)));
-
- EXPECT_TRUE(call_.GetAudioSendStream(1234));
- EXPECT_EQ(1234U, voe_.GetLocalSSRC(receive_channel_num));
+ cricket::StreamParams::CreateLegacy(kSsrc1)));
+ EXPECT_TRUE(call_.GetAudioSendStream(kSsrc1));
+ EXPECT_EQ(kSsrc1, GetRecvStreamConfig(kSsrc2).rtp.local_ssrc);
}
// Test that we can properly receive packets.
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698