Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2071573002: Fixing flaky test: WebRtcSessionTest.TestPacketOptionsAndOnPacketSent (Closed)

Created:
4 years, 6 months ago by Taylor Brandstetter
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing flaky test: WebRtcSessionTest.TestPacketOptionsAndOnPacketSent The test sent a media packet, then verified it was sent by checking the "last packet sent"'s ID. But the last packet sent may have been a STUN packet that came *after* the media packet. BUG=webrtc:5978 Committed: https://crrev.com/14461d42bc7ad3710380083cf8857baf61e8952a Cr-Commit-Position: refs/heads/master@{#13156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M tools/valgrind-webrtc/gtest_exclude/peerconnection_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Taylor Brandstetter
4 years, 6 months ago (2016-06-15 17:13:20 UTC) #4
pthatcher1
lgtm
4 years, 6 months ago (2016-06-15 17:34:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071573002/1
4 years, 6 months ago (2016-06-15 17:35:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 18:07:02 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 18:07:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14461d42bc7ad3710380083cf8857baf61e8952a
Cr-Commit-Position: refs/heads/master@{#13156}

Powered by Google App Engine
This is Rietveld 408576698