webrtc/api/webrtcsession_unittest.cc - Issue 2071573002: Fixing flaky test: WebRtcSessionTest.TestPacketOptionsAndOnPacketSent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/webrtcsession_unittest.cc

Issue 2071573002: Fixing flaky test: WebRtcSessionTest.TestPacketOptionsAndOnPacketSent (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/valgrind-webrtc/gtest_exclude/peerconnection_unittests.gtest-drmemory_win32.txt ('k') | webrtc/media/engine/fakewebrtccall.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/api/webrtcsession_unittest.cc

diff --git a/webrtc/api/webrtcsession_unittest.cc b/webrtc/api/webrtcsession_unittest.cc

index 674d54fa5397619ad8c98653ad44c6c9d8b4d724..e8234d7c1b9295ad8428b6d17fd4203e865c6c50 100644

--- a/webrtc/api/webrtcsession_unittest.cc

+++ b/webrtc/api/webrtcsession_unittest.cc

@@ -1326,7 +1326,8 @@ class WebRtcSessionTest

->SendRtp(test_packet, sizeof(test_packet), options);

const int kPacketTimeout = 2000;

- EXPECT_EQ_WAIT(fake_call_.last_sent_packet().packet_id, 10, kPacketTimeout);

+ EXPECT_EQ_WAIT(10, fake_call_.last_sent_nonnegative_packet_id(),

+ kPacketTimeout);

EXPECT_GT(fake_call_.last_sent_packet().send_time_ms, -1);

}