Chromium Code Reviews

Issue 2069643002: Added backwards compatible version of WebRtcMediaEngineFactory::Create. (Closed)

Created:
4 years, 6 months ago by ossu
Modified:
4 years, 6 months ago
Reviewers:
the sun, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added backwards compatible version of WebRtcMediaEngineFactory::Create. Added notry to unbreak clients quickly. NOTRY=True BUG=webrtc:6000 Committed: https://crrev.com/111744e1d7b12e943d2c214800dc6616b9791146 Cr-Commit-Position: refs/heads/master@{#13150}

Patch Set 1 #

Patch Set 2 : Added tests. #

Unified diffs Side-by-side diffs Stats (+35 lines, -0 lines)
M webrtc/media/engine/webrtcmediaengine.h View 1 chunk +8 lines, -0 lines 0 comments
M webrtc/media/engine/webrtcmediaengine.cc View 2 chunks +13 lines, -0 lines 0 comments
M webrtc/media/engine/webrtcmediaengine_unittest.cc View 2 chunks +14 lines, -0 lines 0 comments

Messages

Total messages: 20 (10 generated)
ossu
Noticed that there might be clients still using the old interface, so I put it ...
4 years, 6 months ago (2016-06-14 15:46:02 UTC) #2
kjellander_webrtc
On 2016/06/14 15:46:02, ossu wrote: > Noticed that there might be clients still using the ...
4 years, 6 months ago (2016-06-15 08:45:42 UTC) #4
ossu
Will do! Added a couple of tests to make sure I didn't make a typo ...
4 years, 6 months ago (2016-06-15 09:04:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069643002/40001
4 years, 6 months ago (2016-06-15 09:15:56 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-15 09:15:59 UTC) #11
the sun
lgtm
4 years, 6 months ago (2016-06-15 09:20:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069643002/40001
4 years, 6 months ago (2016-06-15 09:21:17 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-15 09:22:38 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 09:22:40 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 09:24:07 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/111744e1d7b12e943d2c214800dc6616b9791146
Cr-Commit-Position: refs/heads/master@{#13150}

Powered by Google App Engine