Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: webrtc/media/engine/webrtcmediaengine_unittest.cc

Issue 2069643002: Added backwards compatible version of WebRtcMediaEngineFactory::Create. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added tests. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/webrtcmediaengine.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcmediaengine_unittest.cc
diff --git a/webrtc/media/engine/webrtcmediaengine_unittest.cc b/webrtc/media/engine/webrtcmediaengine_unittest.cc
index f7ae7db73d10bfa0deea19c356c3aa8605211e80..a3e4120e1b5346a89c5c15514294123d858b64d2 100644
--- a/webrtc/media/engine/webrtcmediaengine_unittest.cc
+++ b/webrtc/media/engine/webrtcmediaengine_unittest.cc
@@ -10,6 +10,7 @@
#include "testing/gtest/include/gtest/gtest.h"
+#include "webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.h"
#include "webrtc/media/engine/webrtcmediaengine.h"
using webrtc::RtpExtension;
@@ -179,4 +180,17 @@ TEST(WebRtcMediaEngineTest, FilterRtpExtensions_RemoveRedundantBwe_3) {
EXPECT_EQ(1, filtered.size());
EXPECT_EQ(RtpExtension::kTimestampOffsetUri, filtered[0].uri);
}
+
+TEST(WebRtcMediaEngineFactoryTest, CreateOldApi) {
+ std::unique_ptr<MediaEngineInterface> engine(
+ WebRtcMediaEngineFactory::Create(nullptr, nullptr, nullptr));
+ EXPECT_TRUE(engine);
+}
+
+TEST(WebRtcMediaEngineFactoryTest, CreateWithBuiltinDecoders) {
+ std::unique_ptr<MediaEngineInterface> engine(WebRtcMediaEngineFactory::Create(
+ nullptr, webrtc::CreateBuiltinAudioDecoderFactory(), nullptr, nullptr));
+ EXPECT_TRUE(engine);
+}
+
} // namespace cricket
« no previous file with comments | « webrtc/media/engine/webrtcmediaengine.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698