PRESUBMIT: Fix bug in sources-above-target check.

PRESUBMIT: Fix bug in sources-above-target check.

The current implementation is matching against sources
which sometimes gets too wide (as seen in
https://codereview.webrtc.org/1999113002 where tools.gyp
contains a key 'process_outputs_as_sources', making it fail
on the GYP dependency.
The file checking operations were also performed against
group(0) of the regex match, which is all of it. The regex was
written with the goal of processing what matched group(1), i.e.
what's inside the sources list.

TESTED=I ran git cl presubmit against https://codereview.webrtc.org/1999113002 with this patch applied, without getting any errors.

Committed: https://crrev.com/74290b9d9c686603f1b8cafe9b4131a03485bf0c
Cr-Commit-Position: refs/heads/master@{#13154}

[kjellander_webrtc, 2016-06-15 14:44:16]

Description was changed from

==========
PRESUBMIT: Fix bug in sources-above-target check.

The current implementation is matching against sources
which sometimes gets too wide (as seen in
https://codereview.webrtc.org/1999113002 where tools.gyp
contains a key 'process_outputs_as_sources', making it fail
on the GYP dependency.
The file checking operations were also performed against
group(0) of the regex match, which is all of it. The regex was
written with the goal of processing what matched group(1), i.e.
what's inside the sources list.
==========

to

==========
PRESUBMIT: Fix bug in sources-above-target check.

The current implementation is matching against sources
which sometimes gets too wide (as seen in
https://codereview.webrtc.org/1999113002 where tools.gyp
contains a key 'process_outputs_as_sources', making it fail
on the GYP dependency.
The file checking operations were also performed against
group(0) of the regex match, which is all of it. The regex was
written with the goal of processing what matched group(1), i.e.
what's inside the sources list.

TESTED=I ran git cl presubmit against https://codereview.webrtc.org/1999113002
with this patch applied, without getting any errors.
==========

[kjellander_webrtc, 2016-06-15 14:44:16]

kjellander@webrtc.org changed reviewers:
+ aleloi@webrtc.org, phoglund@webrtc.org

[phoglund, 2016-06-15 14:59:29]

A bug in a regex? Inconceivable!

:) lgtm

[aleloi, 2016-06-16 08:19:03]

lgtm

[kjellander_webrtc, 2016-06-16 08:54:46]

Description was changed from

==========
PRESUBMIT: Fix bug in sources-above-target check.

The current implementation is matching against sources
which sometimes gets too wide (as seen in
https://codereview.webrtc.org/1999113002 where tools.gyp
contains a key 'process_outputs_as_sources', making it fail
on the GYP dependency.
The file checking operations were also performed against
group(0) of the regex match, which is all of it. The regex was
written with the goal of processing what matched group(1), i.e.
what's inside the sources list.

TESTED=I ran git cl presubmit against https://codereview.webrtc.org/1999113002
with this patch applied, without getting any errors.
==========

to

==========
PRESUBMIT: Fix bug in sources-above-target check.

The current implementation is matching against sources
which sometimes gets too wide (as seen in
https://codereview.webrtc.org/1999113002 where tools.gyp
contains a key 'process_outputs_as_sources', making it fail
on the GYP dependency.
The file checking operations were also performed against
group(0) of the regex match, which is all of it. The regex was
written with the goal of processing what matched group(1), i.e.
what's inside the sources list.

TESTED=I ran git cl presubmit against https://codereview.webrtc.org/1999113002
with this patch applied, without getting any errors.

Committed: https://crrev.com/74290b9d9c686603f1b8cafe9b4131a03485bf0c
Cr-Commit-Position: refs/heads/master@{#13154}
==========

[kjellander_webrtc, 2016-06-16 08:55:32]

On 2016/06/16 08:19:03, aleloi wrote:
> lgtm

Odd, this was committed as
https://chromium.googlesource.com/external/webrtc/+/74290b9d9c686603f1b8cafe9...
I must have done something wrong when I patched in aleloi's CL. I should not
commit manually (better use CQ with NOTRY=True).