PRESUBMIT: Fix bug in sources-above-target check.

PRESUBMIT.py

 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import json
 import os
@@ skipping 239 matching lines @@
   if violating_files:
     return [output_api.PresubmitError(
         'Depending on rtc_base is not allowed. Change your dependency to '
         'rtc_base_approved and possibly sanitize and move the desired source '
         'file(s) to rtc_base_approved.\nChanged GYP files:',
         items=violating_files)]
   return []
 
 def _CheckNoSourcesAboveGyp(input_api, gyp_files, output_api):
   # Disallow referencing source files with paths above the GYP file location.
-  source_pattern = input_api.re.compile(r'sources.*?\[(.*?)\]',
+  source_pattern = input_api.re.compile(r'\'sources\'.*?\[(.*?)\]',
                                         re.MULTILINE | re.DOTALL)
   file_pattern = input_api.re.compile(r"'((\.\./.*?)|(<\(webrtc_root\).*?))'")
   violating_gyp_files = set()
   violating_source_entries = []
   for gyp_file in gyp_files:
     if 'supplement.gypi' in gyp_file.LocalPath():
       # Exclude supplement.gypi from this check, as the LSan and TSan
       # suppression files are located in a different location.
       continue
     contents = input_api.ReadFile(gyp_file)
     for source_block_match in source_pattern.finditer(contents):
       # Find all source list entries starting with ../ in the source block
       # (exclude overrides entries).
-      for file_list_match in file_pattern.finditer(source_block_match.group(0)):
-        source_file = file_list_match.group(0)
+      for file_list_match in file_pattern.finditer(source_block_match.group(1)):
+        source_file = file_list_match.group(1)
         if 'overrides/' not in source_file:
           violating_source_entries.append(source_file)
           violating_gyp_files.add(gyp_file)
   if violating_gyp_files:
     return [output_api.PresubmitError(
         'Referencing source files above the directory of the GYP file is not '
         'allowed. Please introduce new GYP targets and/or GYP files in the '
         'proper location instead.\n'
         'Invalid source entries:\n'
         '%s\n'
@@ skipping 249 matching lines @@
     for builder in masters[master]:
       if 'presubmit' in builder:
         # Do not trigger presubmit builders, since they're likely to fail
         # (e.g. OWNERS checks before finished code review), and we're running
         # local presubmit anyway.
         pass
       else:
         try_config[master][builder] = ['defaulttests']
 
   return try_config