webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h - Issue 2061423003: Refactor NACK bitrate allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

Issue 2061423003: Refactor NACK bitrate allocation (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed data race Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

index 369cdca0b2245f0951d7ec47793938c9d55ccac6..6b951dcb8b9254519c4cf029df0dd522555e6386 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

@@ -309,7 +309,7 @@ class ModuleRtpRtcpImpl : public RtpRtcp {

void BitrateSent(uint32_t* total_rate,

uint32_t* video_rate,

uint32_t* fec_rate,

- uint32_t* nackRate) const override;

+ uint32_t* nackRate) override;

// Good state of RTP receiver inform sender.

int32_t SendRTCPReferencePictureSelection(uint64_t picture_id) override;