webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc - Issue 2061423003: Refactor NACK bitrate allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

Issue 2061423003: Refactor NACK bitrate allocation (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed data race Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

index be8ab34a2771117680367ff7e1e4653ec4c3ab01..44ab7dd3a23a372741a1f1559dd46de75b6fa4cb 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

@@ -892,7 +892,7 @@ void ModuleRtpRtcpImpl::SetRemoteSSRC(const uint32_t ssrc) {

void ModuleRtpRtcpImpl::BitrateSent(uint32_t* total_rate,

uint32_t* video_rate,

uint32_t* fec_rate,

- uint32_t* nack_rate) const {

+ uint32_t* nack_rate) {

*total_rate = rtp_sender_.BitrateSent();

*video_rate = rtp_sender_.VideoBitrateSent();

*fec_rate = rtp_sender_.FecOverheadRate();