webrtc/modules/rtp_rtcp/include/rtp_rtcp.h - Issue 2061423003: Refactor NACK bitrate allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 2061423003: Refactor NACK bitrate allocation (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed data race Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

index 7c72e5917c8ab2feb8acdac1c119cd3e25b8b5c6..94ab763a26b1f8e00c999b61987f5e5bc35c0e70 100644

--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

@@ -286,7 +286,7 @@ class RtpRtcp : public Module {

virtual void BitrateSent(uint32_t* totalRate,

uint32_t* videoRate,

uint32_t* fecRate,

- uint32_t* nackRate) const = 0;

danilchap 2016/06/20 16:53:46 this would break downstream code.

sprang_webrtc 2016/06/23 07:54:29 Acknowledged.

+ uint32_t* nackRate) = 0;

* Used by the codec module to deliver a video or audio frame for