Refactor NACK bitrate allocation

webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 268 matching lines @@
     *   get send status
     */
     virtual bool SendingMedia() const = 0;
 
     /*
     *   get sent bitrate in Kbit/s
     */
     virtual void BitrateSent(uint32_t* totalRate,
                              uint32_t* videoRate,
                              uint32_t* fecRate,
-                             uint32_t* nackRate) const = 0;

[danilchap, 2016/06/20 16:53:46]

this would break downstream code.

[sprang_webrtc, 2016/06/23 07:54:29]

Acknowledged.

+                             uint32_t* nackRate) = 0;
 
     /*
     *   Used by the codec module to deliver a video or audio frame for
     *   packetization.
     *
     *   frameType       - type of frame to send
     *   payloadType     - payload type of frame to send
     *   timestamp       - timestamp of frame to send
     *   payloadData     - payload buffer of frame to send
     *   payloadSize     - size of payload buffer to send
@@ skipping 347 matching lines @@
 
     /*
     *   send a request for a keyframe
     *
     *   return -1 on failure else 0
     */
     virtual int32_t RequestKeyFrame() = 0;
 };
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_