Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2060813002: Configure VoE NACK through AudioReceiveStream::Config. (Closed)

Created:
4 years, 6 months ago by the sun
Modified:
4 years, 6 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@wvoe_config_nack
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Configure VoE NACK through AudioReceiveStream::Config, for receive streams. Also minor refactoring of WVoE unit test. BUG=webrtc:4690 Committed: https://crrev.com/8189b02feaae73e542190f79c57e858fd7d84f3d Cr-Commit-Position: refs/heads/master@{#13140}

Patch Set 1 #

Total comments: 2

Patch Set 2 : NackConfig added to AudioReceiveStream::Config::Rtp #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -123 lines) Patch
M webrtc/audio/audio_receive_stream.cc View 1 3 chunks +6 lines, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M webrtc/audio_receive_stream.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 2 3 4 3 chunks +1 line, -14 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 2 3 4 8 chunks +21 lines, -29 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 2 3 4 5 35 chunks +59 lines, -75 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
the sun
4 years, 6 months ago (2016-06-13 10:05:34 UTC) #3
kwiberg-webrtc
lgtm https://codereview.webrtc.org/2060813002/diff/1/webrtc/media/engine/webrtcvoiceengine_unittest.cc File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right): https://codereview.webrtc.org/2060813002/diff/1/webrtc/media/engine/webrtcvoiceengine_unittest.cc#newcode136 webrtc/media/engine/webrtcvoiceengine_unittest.cc:136: } Nice simplification, but it makes the diff ...
4 years, 6 months ago (2016-06-13 13:47:47 UTC) #4
the sun
https://codereview.webrtc.org/2060813002/diff/1/webrtc/media/engine/webrtcvoiceengine_unittest.cc File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right): https://codereview.webrtc.org/2060813002/diff/1/webrtc/media/engine/webrtcvoiceengine_unittest.cc#newcode136 webrtc/media/engine/webrtcvoiceengine_unittest.cc:136: } On 2016/06/13 13:47:47, kwiberg-webrtc wrote: > Nice simplification, ...
4 years, 6 months ago (2016-06-13 16:55:38 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1955363003 Patch 120001). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-14 16:04:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060813002/100001
4 years, 6 months ago (2016-06-14 17:48:50 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-14 19:13:05 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 19:13:17 UTC) #16
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8189b02feaae73e542190f79c57e858fd7d84f3d
Cr-Commit-Position: refs/heads/master@{#13140}

Powered by Google App Engine
This is Rietveld 408576698