Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: webrtc/media/engine/fakewebrtcvoiceengine.h

Issue 2060813002: Configure VoE NACK through AudioReceiveStream::Config. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@wvoe_config_nack
Patch Set: format Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/audio_receive_stream.h ('k') | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/fakewebrtcvoiceengine.h
diff --git a/webrtc/media/engine/fakewebrtcvoiceengine.h b/webrtc/media/engine/fakewebrtcvoiceengine.h
index e15b2e67120b2ebb88fa9078d27787c5727f7ec5..5f0be5c977daf6781691c265b98fcb1eb0c9cbb6 100644
--- a/webrtc/media/engine/fakewebrtcvoiceengine.h
+++ b/webrtc/media/engine/fakewebrtcvoiceengine.h
@@ -134,10 +134,8 @@ class FakeWebRtcVoiceEngine
bool codec_fec = false;
int max_encoding_bandwidth = 0;
bool opus_dtx = false;
- bool nack = false;
int cn8_type = 13;
int cn16_type = 105;
- int nack_max_packets = 0;
uint32_t send_ssrc = 0;
int associate_send_channel = -1;
std::vector<webrtc::CodecInst> recv_codecs;
@@ -176,12 +174,6 @@ class FakeWebRtcVoiceEngine
int GetMaxEncodingBandwidth(int channel) {
return channels_[channel]->max_encoding_bandwidth;
}
- bool GetNACK(int channel) {
- return channels_[channel]->nack;
- }
- int GetNACKMaxPackets(int channel) {
- return channels_[channel]->nack_max_packets;
- }
int GetSendCNPayloadType(int channel, bool wideband) {
return (wideband) ?
channels_[channel]->cn16_type :
@@ -477,12 +469,7 @@ class FakeWebRtcVoiceEngine
WEBRTC_STUB(GetRTCPStatistics, (int channel, webrtc::CallStatistics& stats));
WEBRTC_STUB(SetREDStatus, (int channel, bool enable, int redPayloadtype));
WEBRTC_STUB(GetREDStatus, (int channel, bool& enable, int& redPayloadtype));
- WEBRTC_FUNC(SetNACKStatus, (int channel, bool enable, int maxNoPackets)) {
- WEBRTC_CHECK_CHANNEL(channel);
- channels_[channel]->nack = enable;
- channels_[channel]->nack_max_packets = maxNoPackets;
- return 0;
- }
+ WEBRTC_STUB(SetNACKStatus, (int channel, bool enable, int maxNoPackets));
// webrtc::VoEVolumeControl
WEBRTC_STUB(SetSpeakerVolume, (unsigned int));
« no previous file with comments | « webrtc/audio_receive_stream.h ('k') | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698