Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2059403002: Removed GetOutputVolume() and SetOutputVolume(). (Closed)

Created:
4 years, 6 months ago by the sun
Modified:
4 years, 6 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed unused GetOutputVolume() and SetOutputVolume() from MediaEngineInterface. BUG=webrtc:4690 Committed: https://crrev.com/05b9803c8ef344ac3dc8fb59504b87a227a0d39d Cr-Commit-Position: refs/heads/master@{#13135}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -127 lines) Patch
M webrtc/media/base/fakemediaengine.h View 1 4 chunks +1 line, -13 lines 0 comments Download
M webrtc/media/base/mediaengine.h View 2 chunks +0 lines, -13 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M webrtc/pc/channelmanager.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/pc/channelmanager.cc View 4 chunks +0 lines, -40 lines 1 comment Download
M webrtc/pc/channelmanager_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
the sun
4 years, 6 months ago (2016-06-14 11:38:44 UTC) #3
tommi
lgtm https://codereview.webrtc.org/2059403002/diff/20001/webrtc/pc/channelmanager.cc File webrtc/pc/channelmanager.cc (left): https://codereview.webrtc.org/2059403002/diff/20001/webrtc/pc/channelmanager.cc#oldcode407 webrtc/pc/channelmanager.cc:407: ret &= worker_thread_->Invoke<bool>( I'm especially happy to see ...
4 years, 6 months ago (2016-06-14 14:38:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059403002/20001
4 years, 6 months ago (2016-06-14 14:38:11 UTC) #7
tommi
On 2016/06/14 14:38:07, tommi-webrtc wrote: > lgtm > > https://codereview.webrtc.org/2059403002/diff/20001/webrtc/pc/channelmanager.cc > File webrtc/pc/channelmanager.cc (left): > ...
4 years, 6 months ago (2016-06-14 14:38:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 15:59:52 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 16:00:00 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05b9803c8ef344ac3dc8fb59504b87a227a0d39d
Cr-Commit-Position: refs/heads/master@{#13135}

Powered by Google App Engine
This is Rietveld 408576698