Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: webrtc/pc/channelmanager_unittest.cc

Issue 2059403002: Removed GetOutputVolume() and SetOutputVolume(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/pc/channelmanager.cc ('K') | « webrtc/pc/channelmanager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/channelmanager_unittest.cc
diff --git a/webrtc/pc/channelmanager_unittest.cc b/webrtc/pc/channelmanager_unittest.cc
index e5e7b4f7de400821528c4a04e8e4c3f574f9cbf3..e4e243c8b516d151c2d661988b284ee34f909965 100644
--- a/webrtc/pc/channelmanager_unittest.cc
+++ b/webrtc/pc/channelmanager_unittest.cc
@@ -169,41 +169,6 @@ TEST_F(ChannelManagerTest, NoTransportChannelTest) {
cm_->Terminate();
}
-TEST_F(ChannelManagerTest, GetSetOutputVolumeBeforeInit) {
- int level;
- // Before init, SetOutputVolume() remembers the volume but does not change the
- // volume of the engine. GetOutputVolume() should fail.
- EXPECT_EQ(-1, fme_->output_volume());
- EXPECT_FALSE(cm_->GetOutputVolume(&level));
- EXPECT_FALSE(cm_->SetOutputVolume(-1)); // Invalid volume.
- EXPECT_TRUE(cm_->SetOutputVolume(99));
- EXPECT_EQ(-1, fme_->output_volume());
-
- // Init() will apply the remembered volume.
- EXPECT_TRUE(cm_->Init());
- EXPECT_TRUE(cm_->GetOutputVolume(&level));
- EXPECT_EQ(99, level);
- EXPECT_EQ(level, fme_->output_volume());
-
- EXPECT_TRUE(cm_->SetOutputVolume(60));
- EXPECT_TRUE(cm_->GetOutputVolume(&level));
- EXPECT_EQ(60, level);
- EXPECT_EQ(level, fme_->output_volume());
-}
-
-TEST_F(ChannelManagerTest, GetSetOutputVolume) {
- int level;
- EXPECT_TRUE(cm_->Init());
- EXPECT_TRUE(cm_->GetOutputVolume(&level));
- EXPECT_EQ(level, fme_->output_volume());
-
- EXPECT_FALSE(cm_->SetOutputVolume(-1)); // Invalid volume.
- EXPECT_TRUE(cm_->SetOutputVolume(60));
- EXPECT_EQ(60, fme_->output_volume());
- EXPECT_TRUE(cm_->GetOutputVolume(&level));
- EXPECT_EQ(60, level);
-}
-
TEST_F(ChannelManagerTest, SetVideoRtxEnabled) {
std::vector<VideoCodec> codecs;
const VideoCodec rtx_codec(96, "rtx", 0, 0, 0);
« webrtc/pc/channelmanager.cc ('K') | « webrtc/pc/channelmanager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698