Delete GetExecutablePath and related unused code.

Delete GetExecutablePath and related unused code.

The function GetExecutablePath is a hack with poor portability. Delete
it and its caller GetTestFilePath. The latter was used in
videoframe_unittest.h, where it is replaced by
webrtc::test::ResourcePath.

Delete unused functions declared in base/testutils.h: ReadFile,
GetSiblingDirectory, GetGoogle3Directory, GetTalkDirectory,
CmpHelperFileEq, EXPECT_FILEEQ, ASSERT_FILEEQ.

Delete unused functions declared in media/base/testutils.h:
GetTestFilePath (see above), LoadPlanarYuvTestImage,
DumpPlanarYuvTestImage, ComputePSNR, ComputeSumSquareError.

The functions LoadPlanarYuvTestImage, DumpPlanarYuvTestImage were used
in yuvscaler_unittests.cc and planarfunctions_unittests.cc, under
webrtc/pc. However, these tests are never compiled or run, and appear
not to have been for the last few years, and are therefore deleted
rather than updated. It might make sense to check if libyuv have
comparable tests, and if not, resurrect them as part of libyuv
unittests.

BUG=
R=perkj@webrtc.org

Committed: https://crrev.com/b00dc386d3fe04412f5688266fe5ed5af131a3ee
Cr-Commit-Position: refs/heads/master@{#13163}

[nisse-webrtc, 2016-06-10 10:24:12]

nisse@webrtc.org changed reviewers:
+ perkj@webrtc.org

[nisse-webrtc, 2016-06-10 10:24:13]

Frank, do you know what's the story of the unused libyuv-related unittests? Is
there any reason to keep them (and enable them) within webrtc?

[perkj_webrtc, 2016-06-10 11:44:52]

lgtm

[nisse-webrtc, 2016-06-13 09:02:21]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-06-13 09:02:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058043002/1

[commit-bot: I haz the power, 2016-06-13 09:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 09:05:43]

Try jobs failed on following builders:
  mac_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/10139)

[nisse-webrtc, 2016-06-13 10:54:04]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-06-13 10:54:05]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2058043002/#ps20001 (title:
"Add call to SetExecutablePath. Add link dependency.")

[commit-bot: I haz the power, 2016-06-13 10:54:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058043002/20001

[commit-bot: I haz the power, 2016-06-13 11:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 11:00:45]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14132)

[nisse-webrtc, 2016-06-13 11:02:16]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-06-13 11:02:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058043002/20001

[commit-bot: I haz the power, 2016-06-13 11:10:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 11:10:59]

Try jobs failed on following builders:
  linux_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/15441)

[nisse-webrtc, 2016-06-13 13:46:23]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-06-13 13:46:24]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2058043002/#ps40001 (title:
"Use std::unique_ptr, and fix leak.")

[commit-bot: I haz the power, 2016-06-13 13:46:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058043002/40001

[commit-bot: I haz the power, 2016-06-13 13:52:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 13:53:00]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14145)

[nisse-webrtc, 2016-06-13 13:55:54]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-06-13 13:55:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058043002/40001

[commit-bot: I haz the power, 2016-06-13 14:02:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 14:02:13]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14148)

[nisse-webrtc, 2016-06-13 14:09:08]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-06-13 14:09:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058043002/40001

[commit-bot: I haz the power, 2016-06-13 14:15:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 14:15:23]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14150)

[fbarchard, 2016-06-13 17:35:12]

fbarchard@chromium.org changed reviewers:
+ fbarchard@chromium.org

[fbarchard, 2016-06-13 17:35:12]

Not sure why these are unused but the planar and scalar tests referred to came
from google talk plugin and were ported to webrtc to test the scaling
functionality for the video adapter.
They are somewhat duplicate to the lower level libyuv scaling and planar tests,
but use webrtc's API.
webrtc doesnt run libyuv tests... suggest hooking them up.

[nisse-webrtc, 2016-06-14 08:49:51]

On 2016/06/13 17:35:12, fbarchard wrote:
> Not sure why these are unused but the planar and scalar tests referred to came
> from google talk plugin and were ported to webrtc to test the scaling
> functionality for the video adapter.
> They are somewhat duplicate to the lower level libyuv scaling and planar
tests,
> but use webrtc's API.

As far as I see, these tests only exercise libyuv API functions, not the webrtc
API. So to me, it makes more sense to do this kind of tests within libyuv.

> webrtc doesnt run libyuv tests... suggest hooking them up.

Sounds reasonable. But perhaps in a different cl.

[nisse-webrtc, 2016-06-16 10:00:46]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-06-16 10:00:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058043002/40001

[commit-bot: I haz the power, 2016-06-16 10:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 10:28:54]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[nisse-webrtc, 2016-06-16 10:31:22]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-06-16 10:31:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058043002/40001

[commit-bot: I haz the power, 2016-06-16 10:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 10:41:59]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[nisse-webrtc, 2016-06-16 10:44:49]

Description was changed from

==========
Delete GetExecutablePath and related unused code.

The function GetExecutablePath is a hack with poor portability. Delete
it and its caller GetTestFilePath. The latter was used in
videoframe_unittest.h, where it is replaced by
webrtc::test::ResourcePath.

Delete unused functions declared in base/testutils.h: ReadFile,
GetSiblingDirectory, GetGoogle3Directory, GetTalkDirectory,
CmpHelperFileEq, EXPECT_FILEEQ, ASSERT_FILEEQ.

Delete unused functions declared in media/base/testutils.h:
GetTestFilePath (see above), LoadPlanarYuvTestImage,
DumpPlanarYuvTestImage, ComputePSNR, ComputeSumSquareError.

The functions LoadPlanarYuvTestImage, DumpPlanarYuvTestImage were used
in yuvscaler_unittests.cc and planarfunctions_unittests.cc, under
webrtc/pc. However, these tests are never compiled or run, and appear
not to have been for the last few years, and are therefore deleted
rather than updated. It might make sense to check if libyuv have
comparable tests, and if not, resurrect them as part of libyuv
unittests.

BUG=
==========

to

==========
Delete GetExecutablePath and related unused code.

The function GetExecutablePath is a hack with poor portability. Delete
it and its caller GetTestFilePath. The latter was used in
videoframe_unittest.h, where it is replaced by
webrtc::test::ResourcePath.

Delete unused functions declared in base/testutils.h: ReadFile,
GetSiblingDirectory, GetGoogle3Directory, GetTalkDirectory,
CmpHelperFileEq, EXPECT_FILEEQ, ASSERT_FILEEQ.

Delete unused functions declared in media/base/testutils.h:
GetTestFilePath (see above), LoadPlanarYuvTestImage,
DumpPlanarYuvTestImage, ComputePSNR, ComputeSumSquareError.

The functions LoadPlanarYuvTestImage, DumpPlanarYuvTestImage were used
in yuvscaler_unittests.cc and planarfunctions_unittests.cc, under
webrtc/pc. However, these tests are never compiled or run, and appear
not to have been for the last few years, and are therefore deleted
rather than updated. It might make sense to check if libyuv have
comparable tests, and if not, resurrect them as part of libyuv
unittests.

BUG=
R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/b00dc386d3fe04412f5688266...
==========

[nisse-webrtc, 2016-06-16 10:44:50]

Committed patchset #4 (id:60001) manually as
b00dc386d3fe04412f5688266fe5ed5af131a3ee (presubmit successful).

[commit-bot: I haz the power, 2016-06-16 10:44:52]

Description was changed from

==========
Delete GetExecutablePath and related unused code.

The function GetExecutablePath is a hack with poor portability. Delete
it and its caller GetTestFilePath. The latter was used in
videoframe_unittest.h, where it is replaced by
webrtc::test::ResourcePath.

Delete unused functions declared in base/testutils.h: ReadFile,
GetSiblingDirectory, GetGoogle3Directory, GetTalkDirectory,
CmpHelperFileEq, EXPECT_FILEEQ, ASSERT_FILEEQ.

Delete unused functions declared in media/base/testutils.h:
GetTestFilePath (see above), LoadPlanarYuvTestImage,
DumpPlanarYuvTestImage, ComputePSNR, ComputeSumSquareError.

The functions LoadPlanarYuvTestImage, DumpPlanarYuvTestImage were used
in yuvscaler_unittests.cc and planarfunctions_unittests.cc, under
webrtc/pc. However, these tests are never compiled or run, and appear
not to have been for the last few years, and are therefore deleted
rather than updated. It might make sense to check if libyuv have
comparable tests, and if not, resurrect them as part of libyuv
unittests.

BUG=
R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/b00dc386d3fe04412f5688266...
==========

to

==========
Delete GetExecutablePath and related unused code.

The function GetExecutablePath is a hack with poor portability. Delete
it and its caller GetTestFilePath. The latter was used in
videoframe_unittest.h, where it is replaced by
webrtc::test::ResourcePath.

Delete unused functions declared in base/testutils.h: ReadFile,
GetSiblingDirectory, GetGoogle3Directory, GetTalkDirectory,
CmpHelperFileEq, EXPECT_FILEEQ, ASSERT_FILEEQ.

Delete unused functions declared in media/base/testutils.h:
GetTestFilePath (see above), LoadPlanarYuvTestImage,
DumpPlanarYuvTestImage, ComputePSNR, ComputeSumSquareError.

The functions LoadPlanarYuvTestImage, DumpPlanarYuvTestImage were used
in yuvscaler_unittests.cc and planarfunctions_unittests.cc, under
webrtc/pc. However, these tests are never compiled or run, and appear
not to have been for the last few years, and are therefore deleted
rather than updated. It might make sense to check if libyuv have
comparable tests, and if not, resurrect them as part of libyuv
unittests.

BUG=
R=perkj@webrtc.org

Committed: https://crrev.com/b00dc386d3fe04412f5688266fe5ed5af131a3ee
Cr-Commit-Position: refs/heads/master@{#13163}
==========