Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 2056683002: Revert of Re-enable UBsan on AGC. (Closed)

Created:
4 years, 6 months ago by åsapersson
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Re-enable UBsan on AGC. (patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/ ) Reason for revert: Breaks bot. Original issue's description: > Re-enable UBsan on AGC. > > BUG=webrtc:5530 > > Committed: https://crrev.com/293c86d67384c15f46b8296096a62a14b4a58d33 > Cr-Commit-Position: refs/heads/master@{#13034} R=kjellander@webrtc.org, peah@webrtc.org TBR=kjellander@webrtc.org, minyue@webrtc.org, peah@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5530 Committed: https://chromium.googlesource.com/external/webrtc/+/2b9423f7a18145255deb93f2505a4fd1c3fa9ad7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M tools/ubsan/blacklist.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/agc/legacy/analog_agc.c View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/agc/legacy/digital_agc.c View 2 chunks +8 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
åsapersson
Created Revert of Re-enable UBsan on AGC.
4 years, 6 months ago (2016-06-09 11:00:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056683002/1
4 years, 6 months ago (2016-06-09 11:00:34 UTC) #3
kjellander_webrtc
lgtm, but please provide links or examples of failures in the CL description
4 years, 6 months ago (2016-06-09 11:12:11 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/14037)
4 years, 6 months ago (2016-06-09 11:27:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056683002/1
4 years, 6 months ago (2016-06-09 11:48:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/8545)
4 years, 6 months ago (2016-06-09 12:28:14 UTC) #10
peah-webrtc
On 2016/06/09 12:28:14, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-10 04:37:06 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2b9423f7a18145255deb93f2505a4fd1c3fa9ad7 Cr-Commit-Position: refs/heads/master@{#13096}
4 years, 6 months ago (2016-06-10 07:12:52 UTC) #14
åsapersson
4 years, 6 months ago (2016-06-10 07:12:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b9423f7a18145255deb93f2505a4fd1c3fa9ad7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698