Chromium Code Reviews

Issue 2054903002: GN: Enable api,media,pc and p2p for the 'webrtc' target. (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Enable api,media,pc and p2p for the 'webrtc' target. These parts were commented out to avoid breaking the Chromium WebRTC FYI bots. Include them in the WebRTC build to make our bots build as many as possible of our GN targets. BUG=webrtc:5949 NOTRY=True TBR=phoglund@webrtc.org Committed: https://crrev.com/94cee3111c19040e16502037b42d2e8a4cae9429 Cr-Commit-Position: refs/heads/master@{#13097}

Patch Set 1 : #

Unified diffs Side-by-side diffs Stats (+16 lines, -8 lines)
M webrtc/BUILD.gn View 3 chunks +9 lines, -7 lines 0 comments
M webrtc/modules/utility/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments
M webrtc/test/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments

Messages

Total messages: 17 (11 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-10 08:05:24 UTC) #6
phoglund
lgtm
4 years, 6 months ago (2016-06-10 08:36:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054903002/60001
4 years, 6 months ago (2016-06-10 08:55:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 6 months ago (2016-06-10 08:57:03 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 08:57:06 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 08:57:12 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94cee3111c19040e16502037b42d2e8a4cae9429
Cr-Commit-Position: refs/heads/master@{#13097}

Powered by Google App Engine