Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: webrtc/BUILD.gn

Issue 2054903002: GN: Enable api,media,pc and p2p for the 'webrtc' target. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/utility/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index 5147ecc972a066f8001b043ef0075d238fac6e09..e2eeb7f96ea3ddbf809ccb5ee56494a11dc3c3d9 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -245,15 +245,11 @@ source_set("webrtc") {
deps = [
":webrtc_common",
-
- #"api", # TODO(kjellander): Enable when bugs.webrtc.org/4256 is fixed.
"audio",
"base:rtc_base",
"call",
"common_audio",
"common_video",
-
- #"media", # TODO(kjellander): Enable when bugs.webrtc.org/4256 is fixed.
"modules/audio_coding",
"modules/audio_conference_mixer",
"modules/audio_device",
@@ -265,9 +261,6 @@ source_set("webrtc") {
"modules/utility",
"modules/video_coding",
"modules/video_processing",
-
- #"p2p", # TODO(kjellander): Enable when bugs.webrtc.org/4256 is fixed.
- #"pc", # TODO(kjellander): Enable when bugs.webrtc.org/4256 is fixed.
"system_wrappers",
"tools",
"video",
@@ -276,6 +269,15 @@ source_set("webrtc") {
if (build_with_chromium) {
deps += [ "modules/video_capture" ]
+ } else {
+ # TODO(kjellander): Enable for Chromium as well when bugs.webrtc.org/4256 is
+ # fixed. Right now it's not possible due to circular dependencies.
+ deps += [
+ "api",
+ "media",
+ "p2p",
+ "pc",
+ ]
}
if (rtc_enable_protobuf) {
« no previous file with comments | « no previous file | webrtc/modules/utility/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698