Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2053093002:
Use relative paths for api/p2p fuzzers. (Closed)
|
Created:
4 years, 6 months ago by pbos-webrtc Modified:
4 years, 6 months ago CC:
tterriberry_mozilla.com, webrtc-reviews_webrtc.org Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionUse relative paths for api/p2p fuzzers.
BUG=
R=aizatsky@chromium.org
TBR=katrielc@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/555cfe9e6e093b01142512de09c8f656308cd043
Patch Set 1 #
Messages
Total messages: 10 (4 generated)
PTAL, pushing this in to faster un-break clusterfuzz libfuzzer.
aizatsky@chromium.org changed reviewers: + aizatsky@chromium.org
lgtm
Description was changed from ========== Use relative paths for api/p2p fuzzers. BUG= TBR=katrielc@webrtc.org ========== to ========== Use relative paths for api/p2p fuzzers. BUG= R=aizatsky@chromium.org TBR=katrielc@webrtc.org ==========
Message was sent while issue was closed.
Description was changed from ========== Use relative paths for api/p2p fuzzers. BUG= R=aizatsky@chromium.org TBR=katrielc@webrtc.org ========== to ========== Use relative paths for api/p2p fuzzers. BUG= R=aizatsky@chromium.org TBR=katrielc@webrtc.org Committed: https://crrev.com/555cfe9e6e093b01142512de09c8f656308cd043 Cr-Commit-Position: refs/heads/master@{#13095} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/555cfe9e6e093b01142512de09c8f656308cd043 Cr-Commit-Position: refs/heads/master@{#13095}
Message was sent while issue was closed.
Description was changed from ========== Use relative paths for api/p2p fuzzers. BUG= R=aizatsky@chromium.org TBR=katrielc@webrtc.org Committed: https://crrev.com/555cfe9e6e093b01142512de09c8f656308cd043 Cr-Commit-Position: refs/heads/master@{#13095} ========== to ========== Use relative paths for api/p2p fuzzers. BUG= R=aizatsky@chromium.org TBR=katrielc@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/555cfe9e6e093b01142512de0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 555cfe9e6e093b01142512de09c8f656308cd043 (presubmit successful).
Message was sent while issue was closed.
On 2016/06/09 at 21:25:32, pbos wrote:
> Committed patchset #1 (id:1) manually as
555cfe9e6e093b01142512de09c8f656308cd043 (presubmit successful).
Still seems to be problematic:
$ ninja -C out/libfuzzer renderer_fuzzer && ./out/libfuzzer/renderer_fuzzer
-use_counters=0 ~/tmp/renderer_fuzzer
ninja: Entering directory `out/libfuzzer'
[1/1] Regenerating ninja files
FAILED: /usr/local/google/home/aizatsky/src/chrome/src/buildtools/linux64/gn
--root=/usr/local/google/home/aizatsky/src/chrome/src -q --check gen
//out/libfuzzer/
ERROR at //content/renderer/media/rtc_video_decoder_factory.h:11:11: Include not
allowed.
#include "third_party/webrtc/media/engine/webrtcvideodecoderfactory.h"
^----------------------------------------------------------
It is not in any dependency of
//content/renderer:renderer
The include file is in the target(s):
//third_party/webrtc/media:rtc_media
which should somehow be reachable.
___________________
ERROR at //content/renderer/media/rtc_dtmf_sender_handler.h:17:11: Include not
allowed.
#include "third_party/webrtc/api/dtmfsenderinterface.h"
^-------------------------------------------
It is not in any dependency of
//content/renderer:renderer
The include file is in the target(s):
//third_party/webrtc/api:libjingle_peerconnection
which should somehow be reachable.
___________________
ERROR at //content/renderer/media/rtc_video_encoder_factory.h:14:11: Include not
allowed.
#include "third_party/webrtc/media/engine/webrtcvideoencoderfactory.h"
^----------------------------------------------------------
It is not in any dependency of
//content/renderer:renderer
The include file is in the target(s):
//third_party/webrtc/media:rtc_media
which should somehow be reachable.
___________________
ERROR at //content/renderer/media/webrtc/stun_field_trial.cc:25:11: Include not
allowed.
#include "third_party/webrtc/p2p/base/packetsocketfactory.h"
^------------------------------------------------
It is not in any dependency of
//content/renderer:renderer
The include file is in the target(s):
//third_party/webrtc/p2p:rtc_p2p
which should somehow be reachable.
___________________
ERROR at //content/renderer/p2p/ipc_socket_factory.h:13:11: Include not allowed.
#include "third_party/webrtc/p2p/base/packetsocketfactory.h"
^------------------------------------------------
It is not in any dependency of
//content/renderer:renderer
The include file is in the target(s):
//third_party/webrtc/p2p:rtc_p2p
which should somehow be reachable.
Message was sent while issue was closed.
On 2016/06/09 22:13:30, aizatsky wrote: > On 2016/06/09 at 21:25:32, pbos wrote: > > Committed patchset #1 (id:1) manually as > 555cfe9e6e093b01142512de09c8f656308cd043 (presubmit successful). > > Still seems to be problematic: > > $ ninja -C out/libfuzzer renderer_fuzzer && ./out/libfuzzer/renderer_fuzzer > -use_counters=0 ~/tmp/renderer_fuzzer > ninja: Entering directory `out/libfuzzer' > [1/1] Regenerating ninja files > FAILED: /usr/local/google/home/aizatsky/src/chrome/src/buildtools/linux64/gn > --root=/usr/local/google/home/aizatsky/src/chrome/src -q --check gen > //out/libfuzzer/ > ERROR at //content/renderer/media/rtc_video_decoder_factory.h:11:11: Include not > allowed. > #include "third_party/webrtc/media/engine/webrtcvideodecoderfactory.h" > ^---------------------------------------------------------- > It is not in any dependency of > //content/renderer:renderer > The include file is in the target(s): > //third_party/webrtc/media:rtc_media > which should somehow be reachable. > ___________________ > ERROR at //content/renderer/media/rtc_dtmf_sender_handler.h:17:11: Include not > allowed. > #include "third_party/webrtc/api/dtmfsenderinterface.h" > ^------------------------------------------- > It is not in any dependency of > //content/renderer:renderer > The include file is in the target(s): > //third_party/webrtc/api:libjingle_peerconnection > which should somehow be reachable. > ___________________ > ERROR at //content/renderer/media/rtc_video_encoder_factory.h:14:11: Include not > allowed. > #include "third_party/webrtc/media/engine/webrtcvideoencoderfactory.h" > ^---------------------------------------------------------- > It is not in any dependency of > //content/renderer:renderer > The include file is in the target(s): > //third_party/webrtc/media:rtc_media > which should somehow be reachable. > ___________________ > ERROR at //content/renderer/media/webrtc/stun_field_trial.cc:25:11: Include not > allowed. > #include "third_party/webrtc/p2p/base/packetsocketfactory.h" > ^------------------------------------------------ > It is not in any dependency of > //content/renderer:renderer > The include file is in the target(s): > //third_party/webrtc/p2p:rtc_p2p > which should somehow be reachable. > ___________________ > ERROR at //content/renderer/p2p/ipc_socket_factory.h:13:11: Include not allowed. > #include "third_party/webrtc/p2p/base/packetsocketfactory.h" > ^------------------------------------------------ > It is not in any dependency of > //content/renderer:renderer > The include file is in the target(s): > //third_party/webrtc/p2p:rtc_p2p > which should somehow be reachable. These got reverted together and looks rolled into chromium, I believe you're fine now. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
