Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: webrtc/voice_engine/channel.h

Issue 2049683003: FileRecorder + FilePlayer: Let Create functions return unique_ptr (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@remove3
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/channel.h
diff --git a/webrtc/voice_engine/channel.h b/webrtc/voice_engine/channel.h
index 34e5c5aff5cd10986399fb7b025545bee76e045e..9c0e39df4f38509670ade4e602e810565faa73df 100644
--- a/webrtc/voice_engine/channel.h
+++ b/webrtc/voice_engine/channel.h
@@ -506,9 +506,9 @@ class Channel
AudioFrame _audioFrame;
// Downsamples to the codec rate if necessary.
PushResampler<int16_t> input_resampler_;
- FilePlayer* _inputFilePlayerPtr;
- FilePlayer* _outputFilePlayerPtr;
- FileRecorder* _outputFileRecorderPtr;
+ std::unique_ptr<FilePlayer> input_file_player_;
+ std::unique_ptr<FilePlayer> output_file_player_;
+ std::unique_ptr<FileRecorder> output_file_recorder_;
int _inputFilePlayerId;
int _outputFilePlayerId;
int _outputFileRecorderId;

Powered by Google App Engine
This is Rietveld 408576698