FileRecorder + FilePlayer: Let Create functions return unique_ptr

webrtc/modules/utility/include/file_recorder.h

Index: webrtc/modules/utility/include/file_recorder.h
diff --git a/webrtc/modules/utility/include/file_recorder.h b/webrtc/modules/utility/include/file_recorder.h
index e04c1e29e1c62c6cdfc5fd54306a362df237f41a..51b497ea39f7be0beb8e2fcbd7b6d6f3908d68d8 100644
--- a/webrtc/modules/utility/include/file_recorder.h
+++ b/webrtc/modules/utility/include/file_recorder.h
@@ -11,6 +11,8 @@
 #ifndef WEBRTC_MODULES_UTILITY_INCLUDE_FILE_RECORDER_H_
 #define WEBRTC_MODULES_UTILITY_INCLUDE_FILE_RECORDER_H_
 
+#include <memory>
+
 #include "webrtc/common_types.h"
 #include "webrtc/engine_configurations.h"
 #include "webrtc/modules/include/module_common_types.h"
@@ -22,10 +24,11 @@ namespace webrtc {
 class FileRecorder {
  public:
   // Note: will return NULL for unsupported formats.
-  static FileRecorder* CreateFileRecorder(const uint32_t instanceID,
-                                          const FileFormats fileFormat);
+  static std::unique_ptr<FileRecorder> CreateFileRecorder(

[ossu, 2016/08/17 11:09:05]

Do we not need to retain compatibility for CreateFileRecorder as well? I can't
find any external uses of it. But if the contruction function for FilePlayer is
renamed, the one for FileRecorder should probably match it.

Or are you aiming for just jumping through hoops right now, so that external
users can update their code, and in a while remove the old CreateFilePlayer and
rename NewFilePlayer?

[kwiberg-webrtc, 2016/08/17 12:27:39]

No, FileRecorder has no external users as far as I know (and I did send out a
PSA about it earlier, so there shouldn't be).
Yes, if create functions are called CreateFoo all through our code base, then
that's what I should do.

[ossu, 2016/08/17 13:49:13]

Acknowledged.

+      const uint32_t instanceID,
+      const FileFormats fileFormat);
 
-  static void DestroyFileRecorder(FileRecorder* recorder);
+  virtual ~FileRecorder() = default;
 
   virtual int32_t RegisterModuleFileCallback(FileCallback* callback) = 0;
 
@@ -49,9 +52,7 @@ class FileRecorder {
 
   // Write frame to file. Frame should contain 10ms of un-ecoded audio data.
   virtual int32_t RecordAudioToFile(const AudioFrame& frame) = 0;
-
- protected:
-  virtual ~FileRecorder() {}
 };
+
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_UTILITY_INCLUDE_FILE_RECORDER_H_