Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2045243002: NetEq: Rename Nack to NackTracker to avoid name collisions in GN (Closed)

Created:
4 years, 6 months ago by hlundin-webrtc
Modified:
4 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Rename Nack to NackTracker to avoid name collisions in GN BUG=webrtc:5949 NOTRY=True R=kjellander@webrtc.org Committed: https://crrev.com/919518613fb1cb4dc777e551b91aa720b3fb690a Cr-Commit-Position: refs/heads/master@{#13069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -993 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/nack.h View 1 chunk +0 lines, -208 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/nack.cc View 1 chunk +0 lines, -231 lines 0 comments Download
A + webrtc/modules/audio_coding/neteq/nack_tracker.h View 7 chunks +16 lines, -16 lines 0 comments Download
A + webrtc/modules/audio_coding/neteq/nack_tracker.cc View 11 chunks +26 lines, -24 lines 0 comments Download
A + webrtc/modules/audio_coding/neteq/nack_tracker_unittest.cc View 12 chunks +24 lines, -23 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/nack_unittest.cc View 1 chunk +0 lines, -482 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
hlundin-webrtc
kjellander, PTAL.
4 years, 6 months ago (2016-06-08 13:19:44 UTC) #1
kjellander_webrtc
lgtm
4 years, 6 months ago (2016-06-08 13:40:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045243002/1
4 years, 6 months ago (2016-06-08 13:42:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 13:43:46 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 13:43:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/919518613fb1cb4dc777e551b91aa720b3fb690a
Cr-Commit-Position: refs/heads/master@{#13069}

Powered by Google App Engine
This is Rietveld 408576698