Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Side by Side Diff: webrtc/modules/audio_coding/neteq/nack_tracker.cc

Issue 2045243002: NetEq: Rename Nack to NackTracker to avoid name collisions in GN (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/modules/audio_coding/neteq/nack.h" 11 #include "webrtc/modules/audio_coding/neteq/nack_tracker.h"
12 12
13 #include <assert.h> // For assert. 13 #include <assert.h> // For assert.
14 14
15 #include <algorithm> // For std::max. 15 #include <algorithm> // For std::max.
16 16
17 #include "webrtc/base/checks.h" 17 #include "webrtc/base/checks.h"
18 #include "webrtc/modules/include/module_common_types.h" 18 #include "webrtc/modules/include/module_common_types.h"
19 #include "webrtc/system_wrappers/include/logging.h" 19 #include "webrtc/system_wrappers/include/logging.h"
20 20
21 namespace webrtc { 21 namespace webrtc {
22 namespace { 22 namespace {
23 23
24 const int kDefaultSampleRateKhz = 48; 24 const int kDefaultSampleRateKhz = 48;
25 const int kDefaultPacketSizeMs = 20; 25 const int kDefaultPacketSizeMs = 20;
26 26
27 } // namespace 27 } // namespace
28 28
29 Nack::Nack(int nack_threshold_packets) 29 NackTracker::NackTracker(int nack_threshold_packets)
30 : nack_threshold_packets_(nack_threshold_packets), 30 : nack_threshold_packets_(nack_threshold_packets),
31 sequence_num_last_received_rtp_(0), 31 sequence_num_last_received_rtp_(0),
32 timestamp_last_received_rtp_(0), 32 timestamp_last_received_rtp_(0),
33 any_rtp_received_(false), 33 any_rtp_received_(false),
34 sequence_num_last_decoded_rtp_(0), 34 sequence_num_last_decoded_rtp_(0),
35 timestamp_last_decoded_rtp_(0), 35 timestamp_last_decoded_rtp_(0),
36 any_rtp_decoded_(false), 36 any_rtp_decoded_(false),
37 sample_rate_khz_(kDefaultSampleRateKhz), 37 sample_rate_khz_(kDefaultSampleRateKhz),
38 samples_per_packet_(sample_rate_khz_ * kDefaultPacketSizeMs), 38 samples_per_packet_(sample_rate_khz_ * kDefaultPacketSizeMs),
39 max_nack_list_size_(kNackListSizeLimit) {} 39 max_nack_list_size_(kNackListSizeLimit) {}
40 40
41 Nack::~Nack() = default; 41 NackTracker::~NackTracker() = default;
42 42
43 Nack* Nack::Create(int nack_threshold_packets) { 43 NackTracker* NackTracker::Create(int nack_threshold_packets) {
44 return new Nack(nack_threshold_packets); 44 return new NackTracker(nack_threshold_packets);
45 } 45 }
46 46
47 void Nack::UpdateSampleRate(int sample_rate_hz) { 47 void NackTracker::UpdateSampleRate(int sample_rate_hz) {
48 assert(sample_rate_hz > 0); 48 assert(sample_rate_hz > 0);
49 sample_rate_khz_ = sample_rate_hz / 1000; 49 sample_rate_khz_ = sample_rate_hz / 1000;
50 } 50 }
51 51
52 void Nack::UpdateLastReceivedPacket(uint16_t sequence_number, 52 void NackTracker::UpdateLastReceivedPacket(uint16_t sequence_number,
53 uint32_t timestamp) { 53 uint32_t timestamp) {
54 // Just record the value of sequence number and timestamp if this is the 54 // Just record the value of sequence number and timestamp if this is the
55 // first packet. 55 // first packet.
56 if (!any_rtp_received_) { 56 if (!any_rtp_received_) {
57 sequence_num_last_received_rtp_ = sequence_number; 57 sequence_num_last_received_rtp_ = sequence_number;
58 timestamp_last_received_rtp_ = timestamp; 58 timestamp_last_received_rtp_ = timestamp;
59 any_rtp_received_ = true; 59 any_rtp_received_ = true;
60 // If no packet is decoded, to have a reasonable estimate of time-to-play 60 // If no packet is decoded, to have a reasonable estimate of time-to-play
61 // use the given values. 61 // use the given values.
62 if (!any_rtp_decoded_) { 62 if (!any_rtp_decoded_) {
63 sequence_num_last_decoded_rtp_ = sequence_number; 63 sequence_num_last_decoded_rtp_ = sequence_number;
(...skipping 14 matching lines...) Expand all
78 78
79 UpdateSamplesPerPacket(sequence_number, timestamp); 79 UpdateSamplesPerPacket(sequence_number, timestamp);
80 80
81 UpdateList(sequence_number); 81 UpdateList(sequence_number);
82 82
83 sequence_num_last_received_rtp_ = sequence_number; 83 sequence_num_last_received_rtp_ = sequence_number;
84 timestamp_last_received_rtp_ = timestamp; 84 timestamp_last_received_rtp_ = timestamp;
85 LimitNackListSize(); 85 LimitNackListSize();
86 } 86 }
87 87
88 void Nack::UpdateSamplesPerPacket(uint16_t sequence_number_current_received_rtp, 88 void NackTracker::UpdateSamplesPerPacket(
89 uint32_t timestamp_current_received_rtp) { 89 uint16_t sequence_number_current_received_rtp,
90 uint32_t timestamp_current_received_rtp) {
90 uint32_t timestamp_increase = 91 uint32_t timestamp_increase =
91 timestamp_current_received_rtp - timestamp_last_received_rtp_; 92 timestamp_current_received_rtp - timestamp_last_received_rtp_;
92 uint16_t sequence_num_increase = 93 uint16_t sequence_num_increase =
93 sequence_number_current_received_rtp - sequence_num_last_received_rtp_; 94 sequence_number_current_received_rtp - sequence_num_last_received_rtp_;
94 95
95 samples_per_packet_ = timestamp_increase / sequence_num_increase; 96 samples_per_packet_ = timestamp_increase / sequence_num_increase;
96 } 97 }
97 98
98 void Nack::UpdateList(uint16_t sequence_number_current_received_rtp) { 99 void NackTracker::UpdateList(uint16_t sequence_number_current_received_rtp) {
99 // Some of the packets which were considered late, now are considered missing. 100 // Some of the packets which were considered late, now are considered missing.
100 ChangeFromLateToMissing(sequence_number_current_received_rtp); 101 ChangeFromLateToMissing(sequence_number_current_received_rtp);
101 102
102 if (IsNewerSequenceNumber(sequence_number_current_received_rtp, 103 if (IsNewerSequenceNumber(sequence_number_current_received_rtp,
103 sequence_num_last_received_rtp_ + 1)) 104 sequence_num_last_received_rtp_ + 1))
104 AddToList(sequence_number_current_received_rtp); 105 AddToList(sequence_number_current_received_rtp);
105 } 106 }
106 107
107 void Nack::ChangeFromLateToMissing( 108 void NackTracker::ChangeFromLateToMissing(
108 uint16_t sequence_number_current_received_rtp) { 109 uint16_t sequence_number_current_received_rtp) {
109 NackList::const_iterator lower_bound = 110 NackList::const_iterator lower_bound =
110 nack_list_.lower_bound(static_cast<uint16_t>( 111 nack_list_.lower_bound(static_cast<uint16_t>(
111 sequence_number_current_received_rtp - nack_threshold_packets_)); 112 sequence_number_current_received_rtp - nack_threshold_packets_));
112 113
113 for (NackList::iterator it = nack_list_.begin(); it != lower_bound; ++it) 114 for (NackList::iterator it = nack_list_.begin(); it != lower_bound; ++it)
114 it->second.is_missing = true; 115 it->second.is_missing = true;
115 } 116 }
116 117
117 uint32_t Nack::EstimateTimestamp(uint16_t sequence_num) { 118 uint32_t NackTracker::EstimateTimestamp(uint16_t sequence_num) {
118 uint16_t sequence_num_diff = sequence_num - sequence_num_last_received_rtp_; 119 uint16_t sequence_num_diff = sequence_num - sequence_num_last_received_rtp_;
119 return sequence_num_diff * samples_per_packet_ + timestamp_last_received_rtp_; 120 return sequence_num_diff * samples_per_packet_ + timestamp_last_received_rtp_;
120 } 121 }
121 122
122 void Nack::AddToList(uint16_t sequence_number_current_received_rtp) { 123 void NackTracker::AddToList(uint16_t sequence_number_current_received_rtp) {
123 assert(!any_rtp_decoded_ || 124 assert(!any_rtp_decoded_ ||
124 IsNewerSequenceNumber(sequence_number_current_received_rtp, 125 IsNewerSequenceNumber(sequence_number_current_received_rtp,
125 sequence_num_last_decoded_rtp_)); 126 sequence_num_last_decoded_rtp_));
126 127
127 // Packets with sequence numbers older than |upper_bound_missing| are 128 // Packets with sequence numbers older than |upper_bound_missing| are
128 // considered missing, and the rest are considered late. 129 // considered missing, and the rest are considered late.
129 uint16_t upper_bound_missing = 130 uint16_t upper_bound_missing =
130 sequence_number_current_received_rtp - nack_threshold_packets_; 131 sequence_number_current_received_rtp - nack_threshold_packets_;
131 132
132 for (uint16_t n = sequence_num_last_received_rtp_ + 1; 133 for (uint16_t n = sequence_num_last_received_rtp_ + 1;
133 IsNewerSequenceNumber(sequence_number_current_received_rtp, n); ++n) { 134 IsNewerSequenceNumber(sequence_number_current_received_rtp, n); ++n) {
134 bool is_missing = IsNewerSequenceNumber(upper_bound_missing, n); 135 bool is_missing = IsNewerSequenceNumber(upper_bound_missing, n);
135 uint32_t timestamp = EstimateTimestamp(n); 136 uint32_t timestamp = EstimateTimestamp(n);
136 NackElement nack_element(TimeToPlay(timestamp), timestamp, is_missing); 137 NackElement nack_element(TimeToPlay(timestamp), timestamp, is_missing);
137 nack_list_.insert(nack_list_.end(), std::make_pair(n, nack_element)); 138 nack_list_.insert(nack_list_.end(), std::make_pair(n, nack_element));
138 } 139 }
139 } 140 }
140 141
141 void Nack::UpdateEstimatedPlayoutTimeBy10ms() { 142 void NackTracker::UpdateEstimatedPlayoutTimeBy10ms() {
142 while (!nack_list_.empty() && 143 while (!nack_list_.empty() &&
143 nack_list_.begin()->second.time_to_play_ms <= 10) 144 nack_list_.begin()->second.time_to_play_ms <= 10)
144 nack_list_.erase(nack_list_.begin()); 145 nack_list_.erase(nack_list_.begin());
145 146
146 for (NackList::iterator it = nack_list_.begin(); it != nack_list_.end(); ++it) 147 for (NackList::iterator it = nack_list_.begin(); it != nack_list_.end(); ++it)
147 it->second.time_to_play_ms -= 10; 148 it->second.time_to_play_ms -= 10;
148 } 149 }
149 150
150 void Nack::UpdateLastDecodedPacket(uint16_t sequence_number, 151 void NackTracker::UpdateLastDecodedPacket(uint16_t sequence_number,
151 uint32_t timestamp) { 152 uint32_t timestamp) {
152 if (IsNewerSequenceNumber(sequence_number, sequence_num_last_decoded_rtp_) || 153 if (IsNewerSequenceNumber(sequence_number, sequence_num_last_decoded_rtp_) ||
153 !any_rtp_decoded_) { 154 !any_rtp_decoded_) {
154 sequence_num_last_decoded_rtp_ = sequence_number; 155 sequence_num_last_decoded_rtp_ = sequence_number;
155 timestamp_last_decoded_rtp_ = timestamp; 156 timestamp_last_decoded_rtp_ = timestamp;
156 // Packets in the list with sequence numbers less than the 157 // Packets in the list with sequence numbers less than the
157 // sequence number of the decoded RTP should be removed from the lists. 158 // sequence number of the decoded RTP should be removed from the lists.
158 // They will be discarded by the jitter buffer if they arrive. 159 // They will be discarded by the jitter buffer if they arrive.
159 nack_list_.erase(nack_list_.begin(), 160 nack_list_.erase(nack_list_.begin(),
160 nack_list_.upper_bound(sequence_num_last_decoded_rtp_)); 161 nack_list_.upper_bound(sequence_num_last_decoded_rtp_));
161 162
162 // Update estimated time-to-play. 163 // Update estimated time-to-play.
163 for (NackList::iterator it = nack_list_.begin(); it != nack_list_.end(); 164 for (NackList::iterator it = nack_list_.begin(); it != nack_list_.end();
164 ++it) 165 ++it)
165 it->second.time_to_play_ms = TimeToPlay(it->second.estimated_timestamp); 166 it->second.time_to_play_ms = TimeToPlay(it->second.estimated_timestamp);
166 } else { 167 } else {
167 assert(sequence_number == sequence_num_last_decoded_rtp_); 168 assert(sequence_number == sequence_num_last_decoded_rtp_);
168 169
169 // Same sequence number as before. 10 ms is elapsed, update estimations for 170 // Same sequence number as before. 10 ms is elapsed, update estimations for
170 // time-to-play. 171 // time-to-play.
171 UpdateEstimatedPlayoutTimeBy10ms(); 172 UpdateEstimatedPlayoutTimeBy10ms();
172 173
173 // Update timestamp for better estimate of time-to-play, for packets which 174 // Update timestamp for better estimate of time-to-play, for packets which
174 // are added to NACK list later on. 175 // are added to NACK list later on.
175 timestamp_last_decoded_rtp_ += sample_rate_khz_ * 10; 176 timestamp_last_decoded_rtp_ += sample_rate_khz_ * 10;
176 } 177 }
177 any_rtp_decoded_ = true; 178 any_rtp_decoded_ = true;
178 } 179 }
179 180
180 Nack::NackList Nack::GetNackList() const { 181 NackTracker::NackList NackTracker::GetNackList() const {
181 return nack_list_; 182 return nack_list_;
182 } 183 }
183 184
184 void Nack::Reset() { 185 void NackTracker::Reset() {
185 nack_list_.clear(); 186 nack_list_.clear();
186 187
187 sequence_num_last_received_rtp_ = 0; 188 sequence_num_last_received_rtp_ = 0;
188 timestamp_last_received_rtp_ = 0; 189 timestamp_last_received_rtp_ = 0;
189 any_rtp_received_ = false; 190 any_rtp_received_ = false;
190 sequence_num_last_decoded_rtp_ = 0; 191 sequence_num_last_decoded_rtp_ = 0;
191 timestamp_last_decoded_rtp_ = 0; 192 timestamp_last_decoded_rtp_ = 0;
192 any_rtp_decoded_ = false; 193 any_rtp_decoded_ = false;
193 sample_rate_khz_ = kDefaultSampleRateKhz; 194 sample_rate_khz_ = kDefaultSampleRateKhz;
194 samples_per_packet_ = sample_rate_khz_ * kDefaultPacketSizeMs; 195 samples_per_packet_ = sample_rate_khz_ * kDefaultPacketSizeMs;
195 } 196 }
196 197
197 void Nack::SetMaxNackListSize(size_t max_nack_list_size) { 198 void NackTracker::SetMaxNackListSize(size_t max_nack_list_size) {
198 RTC_CHECK_GT(max_nack_list_size, 0u); 199 RTC_CHECK_GT(max_nack_list_size, 0u);
199 // Ugly hack to get around the problem of passing static consts by reference. 200 // Ugly hack to get around the problem of passing static consts by reference.
200 const size_t kNackListSizeLimitLocal = Nack::kNackListSizeLimit; 201 const size_t kNackListSizeLimitLocal = NackTracker::kNackListSizeLimit;
201 RTC_CHECK_LE(max_nack_list_size, kNackListSizeLimitLocal); 202 RTC_CHECK_LE(max_nack_list_size, kNackListSizeLimitLocal);
202 203
203 max_nack_list_size_ = max_nack_list_size; 204 max_nack_list_size_ = max_nack_list_size;
204 LimitNackListSize(); 205 LimitNackListSize();
205 } 206 }
206 207
207 void Nack::LimitNackListSize() { 208 void NackTracker::LimitNackListSize() {
208 uint16_t limit = sequence_num_last_received_rtp_ - 209 uint16_t limit = sequence_num_last_received_rtp_ -
209 static_cast<uint16_t>(max_nack_list_size_) - 1; 210 static_cast<uint16_t>(max_nack_list_size_) - 1;
210 nack_list_.erase(nack_list_.begin(), nack_list_.upper_bound(limit)); 211 nack_list_.erase(nack_list_.begin(), nack_list_.upper_bound(limit));
211 } 212 }
212 213
213 int64_t Nack::TimeToPlay(uint32_t timestamp) const { 214 int64_t NackTracker::TimeToPlay(uint32_t timestamp) const {
214 uint32_t timestamp_increase = timestamp - timestamp_last_decoded_rtp_; 215 uint32_t timestamp_increase = timestamp - timestamp_last_decoded_rtp_;
215 return timestamp_increase / sample_rate_khz_; 216 return timestamp_increase / sample_rate_khz_;
216 } 217 }
217 218
218 // We don't erase elements with time-to-play shorter than round-trip-time. 219 // We don't erase elements with time-to-play shorter than round-trip-time.
219 std::vector<uint16_t> Nack::GetNackList(int64_t round_trip_time_ms) const { 220 std::vector<uint16_t> NackTracker::GetNackList(
221 int64_t round_trip_time_ms) const {
220 RTC_DCHECK_GE(round_trip_time_ms, 0); 222 RTC_DCHECK_GE(round_trip_time_ms, 0);
221 std::vector<uint16_t> sequence_numbers; 223 std::vector<uint16_t> sequence_numbers;
222 for (NackList::const_iterator it = nack_list_.begin(); it != nack_list_.end(); 224 for (NackList::const_iterator it = nack_list_.begin(); it != nack_list_.end();
223 ++it) { 225 ++it) {
224 if (it->second.is_missing && 226 if (it->second.is_missing &&
225 it->second.time_to_play_ms > round_trip_time_ms) 227 it->second.time_to_play_ms > round_trip_time_ms)
226 sequence_numbers.push_back(it->first); 228 sequence_numbers.push_back(it->first);
227 } 229 }
228 return sequence_numbers; 230 return sequence_numbers;
229 } 231 }
230 232
231 } // namespace webrtc 233 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/audio_coding/neteq/nack_tracker.h ('k') | webrtc/modules/audio_coding/neteq/nack_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698