Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2044383002: Android: Fix texture leak. (Closed)

Created:
4 years, 6 months ago by nisse-webrtc
Modified:
4 years, 6 months ago
Reviewers:
perkj_webrtc, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, AlexG
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Fix texture leak. The bug fix in https://codereview.webrtc.org/2033943004 was incomplete, and leaks the texture in the case of texture frames arriving during close. See also the similar bug fixed in https://codereview.webrtc.org/2012773004. BUG=webrtc:5966 R=perkj@webrtc.org, sakal@webrtc.org Committed: https://crrev.com/86f7afd44f756cf84011a524e9b8d2d398c1a154 Cr-Commit-Position: refs/heads/master@{#13067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/api/java/jni/androidvideocapturer_jni.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nisse-webrtc
This should hopefully fix the camera freeze problem.
4 years, 6 months ago (2016-06-08 12:04:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044383002/1
4 years, 6 months ago (2016-06-08 12:05:57 UTC) #4
sakal
lgtm
4 years, 6 months ago (2016-06-08 12:14:31 UTC) #5
perkj_webrtc
lgtm
4 years, 6 months ago (2016-06-08 12:51:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044383002/1
4 years, 6 months ago (2016-06-08 12:51:25 UTC) #9
nisse-webrtc
4 years, 6 months ago (2016-06-08 12:59:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86f7afd44f756cf84011a524e9b8d2d398c1a154 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698