Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2033943004: Handle Android stop capturer race. (Closed)

Created:
4 years, 6 months ago by nisse-webrtc
Modified:
4 years, 6 months ago
Reviewers:
perkj_webrtc, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, AlexG
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Handle Android stop capturer race. With the current order of stop capture processing on Android, OnMemoryBufferFrame and OnTextureFrame may be called halfway through Stop(). They must therefore check for the case of a null capturer_. There used to be such checks, but they were accidantally removed in commit #12895, cl https://codereview.webrtc.org/1973873003. BUG=webrtc:5966 R=perkj@webrtc.org, sakal@webrtc.org Committed: https://crrev.com/47183ba60bddfcdd1494d88f3c1fefc62eb9445b Cr-Commit-Position: refs/heads/master@{#13031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M webrtc/api/java/jni/androidvideocapturer_jni.cc View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
nisse-webrtc
This should hopefully fix the Android stop capturer crashes.
4 years, 6 months ago (2016-06-03 09:02:48 UTC) #2
sakal
lgtm
4 years, 6 months ago (2016-06-03 09:12:21 UTC) #3
perkj_webrtc
4 years, 6 months ago (2016-06-03 09:43:04 UTC) #4
perkj_webrtc
lgtm
4 years, 6 months ago (2016-06-03 09:43:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033943004/1
4 years, 6 months ago (2016-06-03 09:58:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/3063)
4 years, 6 months ago (2016-06-03 10:11:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033943004/1
4 years, 6 months ago (2016-06-03 11:04:10 UTC) #11
perkj_webrtc
4 years, 6 months ago (2016-06-03 11:05:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
47183ba60bddfcdd1494d88f3c1fefc62eb9445b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698