Issue 2044333004: GN: Fix Chromium breakage for remote_bitrate_estimator

Issue 2044333004: GN: Fix Chromium breakage for remote_bitrate_estimator (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc

Modified:
4 years, 6 months ago

Reviewers:
stefan-webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

GN: Fix Chromium breakage for remote_bitrate_estimator In https://codereview.webrtc.org/2040313004 a config was changed incorrectly and a dependency on rtc_base_approved is also missing. BUG=webrtc:5949 TBR=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/d4070c63d9e573cf134547eded96f2babd034d4e

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	webrtc/modules/remote_bitrate_estimator/BUILD.gn	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

Patchset 2 (id:??) landed as https://crrev.com/d4070c63d9e573cf134547eded96f2babd034d4e Cr-Commit-Position: refs/heads/master@{#13088}

4 years, 6 months ago (2016-06-09 09:55:45 UTC) #5

kjellander_webrtc

Committed patchset #2 (id:20001) manually as d4070c63d9e573cf134547eded96f2babd034d4e (presubmit successful).

4 years, 6 months ago (2016-06-09 09:55:46 UTC) #6

Message was sent while issue was closed.

lgtm