Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 2040313004: Fix GYP/GN for webrtc/modules/remote_bitrate_estimator (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix GYP/GN for webrtc/modules/remote_bitrate_estimator Sync the GYP and GN targets and update the name of the GN one to 'remote_bitrate_estimator'. Move the GYP variable 'enable_bwe_test_logging' into the local scope. Remove redundant entries in modules.gyp. These are preparations related to the GN migration. BUG=webrtc:5949 TESTED=Ran GYP with the default variables and with -Denable_bwe_test_logging=1. Compiled remote_bitrate_estimator and verified that bwe_test_logging.cc is compiled only when set. NOTRY=True Committed: https://crrev.com/5c1d043726b7caa7f1e2fca598a0f2e930e035d6 Cr-Commit-Position: refs/heads/master@{#13087}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased and restored defines in modules.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -32 lines) Patch
M webrtc/modules/modules.gyp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 2 chunks +16 lines, -21 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 4 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-08 15:17:45 UTC) #2
kjellander_webrtc
PTAL
4 years, 6 months ago (2016-06-09 09:17:51 UTC) #4
stefan-webrtc
lgtm
4 years, 6 months ago (2016-06-09 09:26:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040313004/40001
4 years, 6 months ago (2016-06-09 09:39:24 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 09:41:02 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 09:41:06 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5c1d043726b7caa7f1e2fca598a0f2e930e035d6
Cr-Commit-Position: refs/heads/master@{#13087}

Powered by Google App Engine
This is Rietveld 408576698