Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2037983002: Reland of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
tommi, perkj_webrtc, guidou
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, katrielc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} The only thing that differs from the previous attempt in https://codereview.webrtc.org/1979933002/ is that none of the new targets are not hooked up to the webrtc target in webrtc/BUILD.gn, which should make it not break the chromium.webrtc.fyi bots. Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} in preparation for removing src/third_party/libjingle in Chromium. Changes between previous attempt and the one before that (https://codereview.webrtc.org/1973313002) are: * Added libstunprober target * Adjusted warnings for Chromium's clang plugins * webrtc/pc/externalhmac.{h,cc} added for Chromium builds. BUG=webrtc:4256 NOTRY=True NOPRESUBMIT=True TBR=perkj@webrtc.org, tommi@webrtc.org Committed: https://crrev.com/c76dc95daf5e494818fd0a2e2ff28af2fb602fbf Cr-Commit-Position: refs/heads/master@{#13030}

Patch Set 1 : Pristine revert CL #

Patch Set 2 : New changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+782 lines, -16 lines) Patch
M webrtc/BUILD.gn View 1 3 chunks +11 lines, -0 lines 0 comments Download
M webrtc/api/BUILD.gn View 1 chunk +127 lines, -0 lines 0 comments Download
M webrtc/build/webrtc.gni View 3 chunks +13 lines, -0 lines 0 comments Download
A + webrtc/libjingle/xmllite/BUILD.gn View 2 chunks +34 lines, -16 lines 0 comments Download
A webrtc/libjingle/xmpp/BUILD.gn View 1 chunk +154 lines, -0 lines 0 comments Download
A webrtc/media/BUILD.gn View 1 chunk +206 lines, -0 lines 0 comments Download
A webrtc/p2p/BUILD.gn View 1 chunk +155 lines, -0 lines 0 comments Download
A webrtc/pc/BUILD.gn View 1 chunk +76 lines, -0 lines 0 comments Download
M webrtc/pc/pc.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-03 08:28:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037983002/40001
4 years, 6 months ago (2016-06-03 10:09:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-03 10:09:35 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 10:09:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c76dc95daf5e494818fd0a2e2ff28af2fb602fbf
Cr-Commit-Position: refs/heads/master@{#13030}

Powered by Google App Engine
This is Rietveld 408576698