Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 1973313002: Reland of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} in preparation for removing src/third_party/libjingle in Chromium. BUG=webrtc:4256 NOTRY=True TBR=perkj@webrtc.org Committed: https://crrev.com/c8d848b1049d8b9e8e33e023d13bec1180dd4926 Cr-Commit-Position: refs/heads/master@{#12731}

Patch Set 1 : Pristine reverted CL #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+745 lines, -16 lines) Patch
M webrtc/BUILD.gn View 3 chunks +8 lines, -0 lines 0 comments Download
M webrtc/api/BUILD.gn View 1 chunk +127 lines, -0 lines 0 comments Download
M webrtc/build/webrtc.gni View 3 chunks +12 lines, -0 lines 0 comments Download
A + webrtc/libjingle/xmllite/BUILD.gn View 3 chunks +30 lines, -16 lines 0 comments Download
A webrtc/libjingle/xmpp/BUILD.gn View 1 chunk +154 lines, -0 lines 0 comments Download
A webrtc/media/BUILD.gn View 1 1 chunk +206 lines, -0 lines 0 comments Download
A webrtc/p2p/BUILD.gn View 1 chunk +138 lines, -0 lines 0 comments Download
A webrtc/pc/BUILD.gn View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
kjellander_webrtc
Relanding this after verifying the CL passes a build of Chromium with this CL patched
4 years, 7 months ago (2016-05-13 15:58:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973313002/20001
4 years, 7 months ago (2016-05-13 15:59:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973313002/20001
4 years, 7 months ago (2016-05-13 16:01:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973313002/20001
4 years, 7 months ago (2016-05-13 17:23:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 17:24:54 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c8d848b1049d8b9e8e33e023d13bec1180dd4926 Cr-Commit-Position: refs/heads/master@{#12731}
4 years, 7 months ago (2016-05-13 17:25:02 UTC) #15
kjellander_webrtc
4 years, 7 months ago (2016-05-13 17:28:35 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1975223002/ by kjellander@webrtc.org.

The reason for reverting is: Breaks GN in Chromium (again), even though I tested
this configuration:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui....

Powered by Google App Engine
This is Rietveld 408576698