Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2037403003: GN: Fix errors in rtc_include_tests conditions (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
clearly one shall not TBR :P
4 years, 6 months ago (2016-06-06 21:03:57 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aff499c9bf7e35cb0f5faf9a016ec97fb94c9e1c Cr-Commit-Position: refs/heads/master@{#13055}
4 years, 6 months ago (2016-06-06 21:04:22 UTC) #3
kjellander_webrtc
Committed patchset #1 (id:1) manually as aff499c9bf7e35cb0f5faf9a016ec97fb94c9e1c (presubmit successful).
4 years, 6 months ago (2016-06-06 21:04:26 UTC) #5
phoglund
4 years, 6 months ago (2016-06-08 07:17:54 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698