Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2043873003: GN: Use rtc_include_tests variable to exclude tests. (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Use rtc_include_tests variable to exclude tests. This is closer to what the GYP build does, and is more readable. BUG=webrtc:5949 TBR=phoglund@webrtc.org NOTRY=True Committed: https://crrev.com/e72db175568083c97528fcc74c37a35992c3bc44 Cr-Commit-Position: refs/heads/master@{#13054}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M build_overrides/webrtc.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/BUILD.gn View 1 chunk +1 line, -2 lines 1 comment Download
M webrtc/base/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/tools/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-06 20:54:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043873003/1
4 years, 6 months ago (2016-06-06 20:58:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 21:00:08 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e72db175568083c97528fcc74c37a35992c3bc44 Cr-Commit-Position: refs/heads/master@{#13054}
4 years, 6 months ago (2016-06-06 21:00:18 UTC) #11
phoglund
4 years, 6 months ago (2016-06-08 07:17:00 UTC) #12
Message was sent while issue was closed.
This patch is wrong but I see you noticed it in a later patch :)

https://codereview.webrtc.org/2043873003/diff/1/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/2043873003/diff/1/webrtc/BUILD.gn#newcode382
webrtc/BUILD.gn:382: if (!rtc_include_tests) {
Uh oh.

Powered by Google App Engine
This is Rietveld 408576698