Use picture id to check continuity between frames.

Use picture id to check continuity between frames.

BUG=webrtc:5514
Committed: https://crrev.com/647998cccfd3cab3233106a223e71fa5de59ab0b
Cr-Commit-Position: refs/heads/master@{#13038}

[philipel, 2016-06-03 13:25:08]

philipel@webrtc.org changed reviewers:
+ pbos@webrtc.org

[philipel, 2016-06-03 13:25:09]

You like jitter buffer yes?

[pbos-webrtc, 2016-06-03 13:26:55]

https://codereview.webrtc.org/2036913003/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder.cc (right):

https://codereview.webrtc.org/2036913003/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.cc:76: if (picture_id !=
-1) {
Can't this check kNoPictureId?

https://codereview.webrtc.org/2036913003/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder.h (right):

https://codereview.webrtc.org/2036913003/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.h:55: int picture_id =
-1) EXCLUSIVE_LOCKS_REQUIRED(crit_);
no default arguments, Google style

[philipel, 2016-06-03 14:17:14]

https://codereview.webrtc.org/2036913003/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder.cc (right):

https://codereview.webrtc.org/2036913003/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.cc:76: if (picture_id !=
-1) {
On 2016/06/03 13:26:55, pbos-webrtc wrote:
> Can't this check kNoPictureId?

Done.

https://codereview.webrtc.org/2036913003/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder.h (right):

https://codereview.webrtc.org/2036913003/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.h:55: int picture_id =
-1) EXCLUSIVE_LOCKS_REQUIRED(crit_);
On 2016/06/03 13:26:55, pbos-webrtc wrote:
> no default arguments, Google style

Done.

[pbos-webrtc, 2016-06-03 14:47:40]

lgtm

[pbos-webrtc, 2016-06-03 14:48:01]

On 2016/06/03 14:47:40, pbos-webrtc wrote:
> lgtm

Perhaps it's worth having stefan@/asapersson@ take a look as well though?

[philipel, 2016-06-03 14:51:10]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2016-06-03 14:51:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036913003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2036913003/20001

[commit-bot: I haz the power, 2016-06-03 16:40:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-03 16:40:27]

Description was changed from

==========
Use picture id to check continuity between frames.

BUG=webrtc:5514
==========

to

==========
Use picture id to check continuity between frames.

BUG=webrtc:5514

Committed: https://crrev.com/647998cccfd3cab3233106a223e71fa5de59ab0b
Cr-Commit-Position: refs/heads/master@{#13038}
==========

[commit-bot: I haz the power, 2016-06-03 16:40:28]

Patchset 2 (id:??) landed as
https://crrev.com/647998cccfd3cab3233106a223e71fa5de59ab0b
Cr-Commit-Position: refs/heads/master@{#13038}