Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: webrtc/modules/video_coding/rtp_frame_reference_finder.h

Issue 2036913003: Use picture id to check continuity between frames. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: No default argument for ManageFrameGeneric. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/video_coding/rtp_frame_reference_finder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 30 matching lines...) Expand all
41 static const int kMaxStashedFrames = 10; 41 static const int kMaxStashedFrames = 10;
42 static const int kMaxNotYetReceivedFrames = 20; 42 static const int kMaxNotYetReceivedFrames = 20;
43 static const int kMaxGofSaved = 15; 43 static const int kMaxGofSaved = 15;
44 44
45 rtc::CriticalSection crit_; 45 rtc::CriticalSection crit_;
46 46
47 // Retry finding references for all frames that previously didn't have 47 // Retry finding references for all frames that previously didn't have
48 // all information needed. 48 // all information needed.
49 void RetryStashedFrames() EXCLUSIVE_LOCKS_REQUIRED(crit_); 49 void RetryStashedFrames() EXCLUSIVE_LOCKS_REQUIRED(crit_);
50 50
51 // Find references for generic frames. 51 // Find references for generic frames. If |picture_id| is unspecified
52 void ManageFrameGeneric(std::unique_ptr<RtpFrameObject> frame) 52 // then packet sequence numbers will be used to determine the references
53 EXCLUSIVE_LOCKS_REQUIRED(crit_); 53 // of the frames.
54 void ManageFrameGeneric(std::unique_ptr<RtpFrameObject> frame,
55 int picture_id) EXCLUSIVE_LOCKS_REQUIRED(crit_);
54 56
55 // Find references for Vp8 frames 57 // Find references for Vp8 frames
56 void ManageFrameVp8(std::unique_ptr<RtpFrameObject> frame) 58 void ManageFrameVp8(std::unique_ptr<RtpFrameObject> frame)
57 EXCLUSIVE_LOCKS_REQUIRED(crit_); 59 EXCLUSIVE_LOCKS_REQUIRED(crit_);
58 60
59 // Updates all necessary state used to determine frame references 61 // Updates all necessary state used to determine frame references
60 // for Vp8 and then calls the |frame_callback| callback with the 62 // for Vp8 and then calls the |frame_callback| callback with the
61 // completed frame. 63 // completed frame.
62 void CompletedFrameVp8(std::unique_ptr<RtpFrameObject> frame) 64 void CompletedFrameVp8(std::unique_ptr<RtpFrameObject> frame)
63 EXCLUSIVE_LOCKS_REQUIRED(crit_); 65 EXCLUSIVE_LOCKS_REQUIRED(crit_);
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 kMaxTemporalLayers> 145 kMaxTemporalLayers>
144 missing_frames_for_layer_ GUARDED_BY(crit_); 146 missing_frames_for_layer_ GUARDED_BY(crit_);
145 147
146 OnCompleteFrameCallback* frame_callback_; 148 OnCompleteFrameCallback* frame_callback_;
147 }; 149 };
148 150
149 } // namespace video_coding 151 } // namespace video_coding
150 } // namespace webrtc 152 } // namespace webrtc
151 153
152 #endif // WEBRTC_MODULES_VIDEO_CODING_RTP_FRAME_REFERENCE_FINDER_H_ 154 #endif // WEBRTC_MODULES_VIDEO_CODING_RTP_FRAME_REFERENCE_FINDER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/video_coding/rtp_frame_reference_finder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698