Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2035663002: Run "git cl format" on some files before I start to modify them (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 4 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Run "git cl format" on some files before I start to modify them This CL does literally nothing else but run "git cl format --full" on the touched files. NOPRESUBMIT=true Committed: https://crrev.com/a06ce499d6cd71a066b0bf2c8701ddf11fbd2cbe Cr-Commit-Position: refs/heads/master@{#13782}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -692 lines) Patch
M webrtc/modules/utility/include/file_player.h View 1 1 chunk +57 lines, -63 lines 0 comments Download
M webrtc/modules/utility/include/file_recorder.h View 1 1 chunk +24 lines, -31 lines 0 comments Download
M webrtc/modules/utility/source/file_player_impl.h View 1 1 chunk +41 lines, -45 lines 0 comments Download
M webrtc/modules/utility/source/file_player_impl.cc View 1 4 chunks +246 lines, -315 lines 0 comments Download
M webrtc/modules/utility/source/file_player_unittests.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.h View 1 1 chunk +31 lines, -35 lines 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.cc View 1 1 chunk +147 lines, -200 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (14 generated)
kwiberg-webrtc
4 years, 6 months ago (2016-06-02 12:36:00 UTC) #3
the sun
lgtm
4 years, 6 months ago (2016-06-02 18:07:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035663002/1
4 years, 6 months ago (2016-06-22 21:54:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6469)
4 years, 6 months ago (2016-06-22 22:06:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035663002/1
4 years, 6 months ago (2016-06-22 22:33:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/14362)
4 years, 6 months ago (2016-06-22 23:09:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2035663002/80001
4 years, 4 months ago (2016-08-16 11:19:08 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 4 months ago (2016-08-16 12:35:29 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 12:35:33 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a06ce499d6cd71a066b0bf2c8701ddf11fbd2cbe
Cr-Commit-Position: refs/heads/master@{#13782}

Powered by Google App Engine
This is Rietveld 408576698