Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2038513002: FileRecorderImpl and FilePlayerImpl don't need their own .h and .cc files (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 4 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove2
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

FileRecorderImpl and FilePlayerImpl don't need their own .h and .cc files They are implementations of interfaces that are only ever exposed via "create" functions, so the entire class definitions can be put in anonymous namespaces in the .cc files that defines the "create" functions. NOPRESUBMIT=true Committed: https://crrev.com/144dd270560a5a5630414a6ed462e425346cb1eb Cr-Commit-Position: refs/heads/master@{#13794}

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -724 lines) Patch
M webrtc/modules/utility/BUILD.gn View 1 1 chunk +2 lines, -4 lines 0 comments Download
A + webrtc/modules/utility/source/file_player.cc View 1 2 chunks +84 lines, -20 lines 0 comments Download
D webrtc/modules/utility/source/file_player_impl.h View 1 1 chunk +0 lines, -74 lines 0 comments Download
D webrtc/modules/utility/source/file_player_impl.cc View 1 1 chunk +0 lines, -333 lines 0 comments Download
A + webrtc/modules/utility/source/file_recorder.cc View 1 2 chunks +69 lines, -8 lines 0 comments Download
D webrtc/modules/utility/source/file_recorder_impl.h View 1 1 chunk +0 lines, -75 lines 0 comments Download
D webrtc/modules/utility/source/file_recorder_impl.cc View 1 1 chunk +0 lines, -206 lines 0 comments Download
M webrtc/modules/utility/utility.gypi View 1 1 chunk +2 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
kwiberg-webrtc
I've just moved code around, and changed it as little as possible (since it's hard ...
4 years, 4 months ago (2016-08-16 20:43:49 UTC) #6
ossu
lgtm!
4 years, 4 months ago (2016-08-17 09:28:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2038513002/80001
4 years, 4 months ago (2016-08-17 09:32:27 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 4 months ago (2016-08-17 09:46:56 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 09:47:03 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/144dd270560a5a5630414a6ed462e425346cb1eb
Cr-Commit-Position: refs/heads/master@{#13794}

Powered by Google App Engine
This is Rietveld 408576698