webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm - Issue 2035473004: RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm

Issue 2035473004: RTCPeerConnectionInterface.mm createNativeConfiguration and other clean-up. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase with master after which we have to remove dtlsidentitystore.cc from a BUILD.gn file Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« talk/app/webrtc/objc/RTCPeerConnectionInterface+Internal.h ('K') | « webrtc/api/peerconnectioninterface.h ('k') | webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h » ('j') | webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm b/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm

index 0ea17e0d9c196f2372b233b4e643253954d74166..e37b99a3eea11a01ec2fe35cee8416a1ce1ade35 100644

--- a/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm

+++ b/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm

@@ -110,7 +110,7 @@

rtc::KeyParams(keyType), rtc::Optional<uint64_t>());

if (!certificate) {

RTCLogError(@"Failed to generate certificate.");

- return nullptr;

+ return nil;

tkchin_webrtc 2016/06/03 23:36:40 ditto nullptr since webrtc::PeerConnectionInterfac

hbos 2016/06/05 11:08:53 Done.

}

nativeConfig->certificates.push_back(certificate);

}