Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2033433004: Remove the unused video stuff in FilePlayer and FileRecorder (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 6 months ago
Reviewers:
the sun, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the unused video stuff in FilePlayer and FileRecorder NOTRY=true Committed: https://crrev.com/821942d8b29b41778c3f03757d42112d6e9887c2 Cr-Commit-Position: refs/heads/master@{#13260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -56 lines) Patch
M webrtc/modules/utility/include/file_player.h View 2 chunks +0 lines, -25 lines 0 comments Download
M webrtc/modules/utility/include/file_recorder.h View 3 chunks +0 lines, -18 lines 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.h View 2 chunks +1 line, -12 lines 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
kwiberg-webrtc
Because I wanted to get rid of all the video stuff before I move this ...
4 years, 6 months ago (2016-06-02 11:59:37 UTC) #2
perkj_webrtc
lgtm
4 years, 6 months ago (2016-06-02 13:45:01 UTC) #3
the sun
lgtm
4 years, 6 months ago (2016-06-02 16:56:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033433004/1
4 years, 6 months ago (2016-06-22 19:56:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/14351)
4 years, 6 months ago (2016-06-22 20:26:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033433004/1
4 years, 6 months ago (2016-06-22 20:41:06 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 20:46:55 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 20:47:04 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/821942d8b29b41778c3f03757d42112d6e9887c2
Cr-Commit-Position: refs/heads/master@{#13260}

Powered by Google App Engine
This is Rietveld 408576698